Core-workflow: When cherry_picker fails, drop you off in the checkout

Created on 17 Mar 2017  路  5Comments  路  Source: python/core-workflow

I just had a cherry-pick fail, but because I was running cherry_picker from its own git repo it took me a minute to realize that I couldn't find the failed branch because I had not cd cpython yet. It might work out better to automatically cd into the checkout upon failure (with an appropriate message that this was done).

cherry_picker.py

Most helpful comment

If we did decide to do this (and I think it's reasonable for the interactive case), it would be helpful if it printed two things before exiting:

  • a command to finish just the "commit-and-push-and-open-web-browser" steps for the current target branch
  • a command to run the cherry-pick again for any not yet processed branches

All 5 comments

Sorry about that.. yeah it's definitely something that I need to address. Maybe related to https://github.com/python/core-workflow/issues/45 too

@Mariatta Nothing to apologize for! Tool worked out great (only issue is GitHub seems to keep thinking I might want to create a PR for the 3.5 branch)!

If we did decide to do this (and I think it's reasonable for the interactive case), it would be helpful if it printed two things before exiting:

  • a command to finish just the "commit-and-push-and-open-web-browser" steps for the current target branch
  • a command to run the cherry-pick again for any not yet processed branches

Hmm.. I couldn't figure out how to actually cd to the cpython directory and let it persist there after cherry_picker.py ended 馃槄 So instead I'm printing out the message that you need to cd cpython first..

Once https://github.com/python/core-workflow/pull/99 is merged, this is not needed anymore since the people will be cherry-picking from cpython directory.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ammaraskar picture ammaraskar  路  9Comments

brettcannon picture brettcannon  路  7Comments

corona10 picture corona10  路  7Comments

serhiy-storchaka picture serhiy-storchaka  路  5Comments

ncoghlan picture ncoghlan  路  9Comments