Copilot-cli: Check no changes err in DelegateDNS in cf/project.go

[kohidave]

Right now, in the DelegateDNS function in project.go, we call update here. If there's an error, we bubble it up and it eventually stops environment creation, this is fine.

We should, however, swallow the errChangeSetEmpty error - since it just means there were no updates needed.

Right now, if you run env init twice, and this delegation was successful the first time, it will cause the the update to fail.

[efekarakus]

Thank you for this insightful issue.

[sandyleo26]

happy to take on this. is it ok for non-first time contributor to tackle another "good first issue"?

[efekarakus]

Hi @sandyleo26!

It's totally okay for a non-first time contributor to tackle another "good first issue"! They're used more as an indicator on how much prior knowledge you might need about the codebase.