Controller-runtime: Support non-CRUD subresources (like pod logs)

Created on 29 May 2019 · 16Comments · Source: kubernetes-sigs/controller-runtime

Hi I am one of the maintainers @kubeflow

We are using kubebuilder to implement some CRDs for Machine Learning/Deep Learning workloads. We meet some problems with the client in controller-runtime.

We need to get the logs of pods using the client, But It seems that controller-runtime client has a higher level abstraction on top of Kubernetes client. Do we have a plan to support expansion (e.g. https://github.com/kubernetes/client-go/blob/master/kubernetes/typed/core/v1/pod_expansion.go) for the client? Or is there any suggestion to do it with controller-runtime client?

Now we have to create a Kubernetes client and use this to get pod logs.

I'd appreciate it if anyone could help me.

Thanks :clinking_glasses: :beers:

help wanted kindesign kinfeature lifecyclfrozen prioritbacklog

Source

gaocegege

👍6

Most helpful comment

We had some plans for supporting subresources, but haven't gotten around to them yet. If you put forth a proposed design, I'd be happy to take a look. We'd have to add support for the wonky streaming that logs uses, since right now the client just deals with CRUD.

DirectXMan12 on 1 Jun 2019

👍2

All 16 comments

/kind feature

DirectXMan12 on 31 May 2019

DirectXMan12 on 1 Jun 2019

👍2

/priority backlog

DirectXMan12 on 1 Jun 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 30 Aug 2019

So, we'll get generic subresource support eventually, but non-CRUD subresources need to be handled specially

DirectXMan12 on 3 Sep 2019

cc #172 (which is mainly for CRUD subresources ATM)

DirectXMan12 on 3 Sep 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 3 Oct 2019

/remove-lifecycle rotten

gaocegege on 6 Oct 2019

/lifecycle frozen

DirectXMan12 on 7 Oct 2019

/help

vincepri on 20 Feb 2020

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.