When reviewing PRs and deciding on a release version, it would be helpful to know if branches of controller-runtime contain any breaking changes:
master and the PR branchmasterFor the recent bumps for Kubernetes 1.15 and 1.16, we used a tool I wrote (go-apidiff) based on Go's experimental apidiff package that checks:
In it's current state, the tool is still a proof-of-concept and probably needs improvements. I haven't had a ton of time to keep up with this, so I'm opening this up to the community to ask for help improving it, finding/fixing bugs, and to potentially incorporate it into controller-runtime's CI to give reviewers a signal of breaking public API changes.
/kind feature
/priority important-soon
/help
From @vincepri:
We're adding go-apidiff prow job in cluster api, we should do the same in controller-runtime at some point https://github.com/kubernetes-sigs/cluster-api/pull/2923
We can use this as an example for incorporating into controller-runtime. Thanks @vincepri!
I was looking at this yesterday, missed the open issue. If no one has taken it I can.
/assign
/remove-help
This is closed by #905, #910, and kubernetes/test-infra#17240.
Most helpful comment
I was looking at this yesterday, missed the open issue. If no one has taken it I can.
/assign