Conference-app-2020: Text color in About page does not consider dark mode

Created on 1 Feb 2020  路  3Comments  路  Source: DroidKaigi/conference-app-2020

Overview (Required)

textColor for the texts in About page refers directly to color resources, so their color does not change according to the change of the app's theme.

Steps To Reproduce

  1. Go to 'Settings'
  2. Set theme to 'Dark'
  3. Go to 'About'

Expected behavior

Text color should be changed corresponding to selected color theme; i.e. use theme's color attribute for the value of textColor.

Screenshots

| Light | Dark |
| -- | -- |
| light | dark |

Env:

  • Device: Pixel3
  • OS: 10
  • App Version or the branch [e.g. 0.1.0 or master]: master
bug high priority welcome contribute

Most helpful comment

@clockvoid 馃檰

All 3 comments

Thanks for reporting!

I could fix it.
The color of version number text was not destined, so I use white in dark mode.
May I make PR with this result?

| Light | Dark |
| ----- | ----- |
| | |

@clockvoid 馃檰

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ry-itto picture ry-itto  路  4Comments

rmakiyama picture rmakiyama  路  6Comments

takahirom picture takahirom  路  8Comments

nukka123 picture nukka123  路  6Comments

rkonno picture rkonno  路  5Comments