Conference-app-2020: defines the default animation

[rmakiyama]

Kind (Required)

• Other

  Overview (Required)

• defines the default animation for navigation component.

https://github.com/DroidKaigi/conference-app-2020/blob/master/corecomponent/androidcomponent/src/main/res/navigation/navigation.xml#L14

[ochim]

I want to contribute.
But I don't understand the aim of this issue.
modify @anim/fade_in and @anim/fade_out ?
add new animation files ?

[takahirom]

Thank you for the comment! 👍
We should implement the XML attribute for all actions.
But we don't want to create boilerplate.

app:enterAnim="@anim/fade_in"
            app:exitAnim="@anim/fade_out"
            app:popEnterAnim="@anim/fade_in"
            app:popExitAnim="@anim/fade_out"

https://github.com/DroidKaigi/conference-app-2020/blob/master/corecomponent/androidcomponent/src/main/res/navigation/navigation.xml#L14

So we want to add default animation.

[ochim]

OK, I see.
The boilerplate is wordy.
But I can't find the solution. Sorry

[takahirom]

It's ok. me too 😄

[umakoz]

I wanna try. 🙋‍♂️

[takahirom]

Thanks! Assigned