Conference-app-2020: Home button is difficult to see in dark Theme.

[CookieySun]

Kind (Required)

• Improvement

  Overview (Required)

• Home button is difficult to see in dark Theme.

• For example, change to white

Screenshot

[KeithYokoma]

@kkt-yu Thank you for reporting the issue 🎉

By the way, could you put a screenshot here so that everyone can have an idea where the issue exists?

[S-Shimotori]

Thank you for your feedback!

I guess Dark __Theme__ is better because this repository includes iOS project.

[CookieySun]

Thank you some feedbacks.

[shinya-takano]

I Changed to Trial white.
I think white is easy to see.
If there is no problem, i create pull request.

[takahirom]

Thanks for trying👍
I want to create an app that uses the entire screen, so I don't want to narrow the screen if possible.

[mukaiyachidaiki]

What about such a fix?
When using a dark theme on Android9 or lower, set NavigationBar to a color with low transparency.
Sorry, I didn't know how to change the button color.

Android 8 Dark

Android 8 Light

Android 10 Dark

Android 10 Light

[takahirom]

How about changing navigation bar when only DarkTheme?👀

[mukaiyachidaiki]

@takahirom
Prepare LiveData in SystemUiManager in a form similar to the status bar, and change the color of the navigation bar according to the OS version when Context.isNightMode changes.

(Referenced code) MainActivity L216

statusBarColors.statusBarColor.distinctUntilChanged().observe(this) { color ->
    window.statusBarColor = color
}

[mukaiyachidaiki]

(英語苦手なので見当違いな回答していたらすみません！)

[takahirom]

@mukaiyachidaiki Sorry for late! looks good!

[mukaiyachidaiki]

I will try this:raising_hand:

[FujiKinaga]

@mukaiyachidaiki
Assigned!👍