Conference-app-2020: Enable R8

Created on 15 Jan 2020  路  10Comments  路  Source: DroidKaigi/conference-app-2020

Kind (Required)

  • Improvement

    Overview (Required)

  • I want to optimize the app using R8馃敟

    Links

-

welcome contribute
Source
picture takahirom

All 10 comments

馃檵鈥嶁檪馃敟

tarumzu picture tarumzu on 15 Jan 2020

馃敟馃敟馃敟馃敟馃敟馃敟

takahirom picture takahirom on 15 Jan 2020

Assigned 馃敟馃敟

roana0229 picture roana0229 on 15 Jan 2020

I'm curious about how to test dynamic feature module applied R8. Can we use internal app sharing?

STAR-ZERO picture STAR-ZERO on 16 Jan 2020

Thank you! Does universal apk make the problem invisible? 馃憖

takahirom picture takahirom on 16 Jan 2020

I'm not sure but I recommend to test the app on internal app sharing or test track before the production release. Navigation to dynamic feature module uses reflection, so it's easy to occur crash.

STAR-ZERO picture STAR-ZERO on 16 Jan 2020
👍1

Indeed. It's absolutely required. I'm still wondering if which distribution track is preferable, but let me integrate a service somehow.

jmatsu picture jmatsu on 16 Jan 2020

@takahirom @tarumzu

AssistedInject is Disable R8's ProGuard compatibility mode.

https://github.com/square/AssistedInject/commit/984b5f80a338205e3ebf86306635d78a06141ec6#diff-503f218d646c10f484fdc9d6315bf2e3

LeoAndo picture LeoAndo on 17 Jan 2020
👀2

I didn't know that!馃槷
Does it affect to app? Not only library?馃憖

takahirom picture takahirom on 17 Jan 2020

@LeoAndo Thank you for the link!
I think It only affects the library.

tarumzu picture tarumzu on 17 Jan 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

nukka123 picture nukka123  路  6Comments
takahirom picture takahirom  路  4Comments
takahirom picture takahirom  路  6Comments
ry-itto picture ry-itto  路  4Comments
rmakiyama picture rmakiyama  路  6Comments