Common-voice: Link "pt-BR" localization to "pt"

Created on 24 Apr 2019  Â·  12Comments  Â·  Source: mozilla/common-voice

Hi,

Dataset languages include Portuguese "pt" without any variants but currently we just have pt-BR localization.

As a temporal way to fix Portuguese dataset collection, I would like to request we use pt-BR localization for pt and enable it on the site, this way we will be able to add sentences.

pt-BR should redirect to pt on the site.

Cheers.

Most helpful comment

pt-BR and pt are spoken quite differently and written somewhat differently.

All 12 comments

pt-BR and pt are spoken quite differently and written somewhat differently.

Let's have a conversation about this before closing the issue, thanks.

Oh sorry, didn't mean to close this.

Based on the conversations we had about language strategy, let's move ahead to avoid blocking Portuguese anymore.

@Gregoor can we mirror for now "pt-BR" into "pt" and enable the site just in "pt"?

@nukeador we can, haven't renamed a locale before, wanna make sure I get the process right. Let's put it onto the todos for next week! (Don't think it'll take long, it's just a first)

@Gregoor @nukeador I am working on something similar for other projects: consolidating two bn-* locales to bn. This is what we are doing so we don't lose the data in Pontoon:

Gregor:

  • create a pt repo
  • move pt-BR repo to pt
  • remove pt-BR repo (let us know when this is done)

Pontoon:

  • disable pt-BR (to stop contributing to the locale)
  • migrate pt-BR data to pt (including contributor's history)
  • L10n PM confirms the update and comment in the issue, so we can close the task.

@peiying2 can you clarify what do you mean by "repo" here?

My understanding is that we should move/rename folders.

Peiying's feedback:

https://github.com/mozilla/voice-web/tree/master/web/locales - I would recommend to make a copy of pt-BR and rename it to pt.

This will allow you to go to all the files containing locale related information and make the necessary changes before removing pt-BR web files.

Make sure this is done in a timely manner if you don't have two locales co-existing for a period of time, but completely switch over. Here are some example of the places you need to make update:

https://github.com/mozilla/voice-web/blob/master/locales/native-names.json
https://github.com/mozilla/voice-web/blob/master/locales/translated.json

@Gregoor please review all proposed changes

https://github.com/mozilla/voice-web/pull/2132

While you are at it, pls remove bn-BD locale too, since you already have bn there.

@peiying2 pt-BT → pt folder change has been committed to master

Changes are now on production

https://voice.mozilla.org/pt

@Gregoor We might want to redirect the old /pt-BR/ url to the new /pt/ one

Oh yeah, good idea! Will do

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Djfe picture Djfe  Â·  5Comments

mikehenrty picture mikehenrty  Â·  3Comments

ivonnekn picture ivonnekn  Â·  4Comments

ivonnekn picture ivonnekn  Â·  5Comments

kenrick95 picture kenrick95  Â·  4Comments