Common-voice: Switching languages - sharing on Twitter, wrong language

[Djfe]

The link to share a statement on twitter uses a get argument for the default message.
Switching the language doesn't update that link to the new language.
Only reloading with F5 does.

[Gregoor]

That's a "bug" in Fluent, which will be fixed soon. We could work-around it on our side, but from my lasy conversation with the fluent team it sounded like it'll be fixed soon.

Some detail: Most of our strings are wrapped in <Localized>-Components which update correctly when the site language changes. But for some cases (like clipboard links) we can't use React Components. For that fluent-react comes with a withLocalization-wrapper which passes the getString-prop to the wrapped component. My inital expectation was that a rerender would be triggered on these components, once the site language changes. That currently isn't the case, hence getString isn't called again .

[Djfe]

thx, for the detailed explanation!
didn't expect that :)
Makes bug reporting more interesting for sure (at least for me since I'm studying computer science)

[Gregoor]

Happy to hear that, then I'll try to be more verbose in general (which is also a good sanity-check for me, to see if my explanations make sense 😁 )

[Djfe]

Well, you certainly can do that, but it of course also takes more time, right? (it's probably best if you decide on your own ^^)
edit: I mean: just keep that in mind.
I still liked the detailed explanation and didn't change my opinion on that though :)

[Gregoor]

@Djfe if you're interested in the details of the fix, you can check out the PR over at the Fluent repo 🙂