Commitlint: Support type-enum: `BREAKING CHANGE` in config-conventional?

Created on 27 Mar 2018  Â·  3Comments  Â·  Source: conventional-changelog/commitlint

Expected Behavior


as stated in https://conventionalcommits.org/, there is a type called BREAKING CHANGE
It should be supported in config-conventional

Current Behavior


it is not supported in config-conventional

Affected packages

  • [x] @commitlint/config-conventional

Possible Solution


  1. add type-enum: BREAKING CHANGE to config-conventional
  2. disable type-case as BREAKING CHANGE is in upper case, even better if it can be the same case as the enum

Your Environment

| Executable | Version |
| ---: | :--- |
| @commitlint/config-conventional --version | 6.1.3 |

Most helpful comment

BREAKING CHANGE isn't truly a type-enum though. It is usually used in conjunction with another type. This already works.

fix(pkg): foo bar

BREAKING CHANGE: baz
echo -e 'fix(pkg): foo bar\n\nBREAKING CHANGE: baz' | $(npm bin)/commitlint
â§—   input: feat: foo
✔   found 0 problems, 0 warnings

All 3 comments

I am happy to submit a PR if we have a consensus here

BREAKING CHANGE isn't truly a type-enum though. It is usually used in conjunction with another type. This already works.

fix(pkg): foo bar

BREAKING CHANGE: baz
echo -e 'fix(pkg): foo bar\n\nBREAKING CHANGE: baz' | $(npm bin)/commitlint
â§—   input: feat: foo
✔   found 0 problems, 0 warnings

you are right, I misunderstood the description
closing this issue as it is not valid...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pixelass picture pixelass  Â·  3Comments

QuentinRoy picture QuentinRoy  Â·  5Comments

texhnolyze picture texhnolyze  Â·  3Comments

kirillgroshkov picture kirillgroshkov  Â·  3Comments

marionebl picture marionebl  Â·  4Comments