Commitlint: Ensure a smooth transition from Angular.js to Angular conventions

Created on 20 Nov 2017  ·  4Comments  ·  Source: conventional-changelog/commitlint

Update 2017-11-30

As discussed with the conventional-changelog team in https://github.com/conventional-changelog/standard-version/pull/220, the way forward for this will be a soft fork from the Angular convention, where we aim for

  • config-conventional: used by conventional-changelog, commitlint, tracks conventionalcommits.org
  • config-angular: used by angular, tracks their commit conventions

For this reason I created the config-conventional package with suggestions what the fork should look like. Work related to conventional-changelog is tracked in https://github.com/conventional-changelog/standard-version/pull/220.

The conventions underpinning config-angular changed with the transition from Angular.js to Angular.

  • chore is no longer allowed as commit type

commitlint reflects this in config-angular@5.

This has not been reflected in the wider ecosystem so far, leading to incompatibilites.
To reinstantiate compat I set the latest tag back to config-angular@4 and tagged config-angular@5 as next.

❯ npm show @commitlint/config-angular .dist-tags
{ latest: '4.3.0', next: '5.0.1' }

❯ npm show commitlint-config-angular .dist-tags
{ latest: '4.3.0', next: '5.0.1' }

Open issues

Related

  • #143
community
Source
picture marionebl

Most helpful comment

@honzajavorek Thanks for reporting, I'll have a closer look at the first one - looks like a bug.

✖   subject must not be sentence-case,start-case,pascal-case,upper-case [subject-case]
picture marionebl on 20 Nov 2017
👍3

All 4 comments

https://greenkeeper.io/ creates chore commits as well.

honzajavorek picture honzajavorek on 20 Nov 2017

Also, I've got following report on the automatic commit made by Greenkeeper:

⧗   input: chore(package): update @commitlint/config-angular to version 5.0.1
✖   subject must not be sentence-case,start-case,pascal-case,upper-case [subject-case]
✖   type must be one of [build, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
✖   found 2 problems, 0 warnings

I don't understand the first one. Why is the commit message chore(package): update @commitlint/config-angular to version 5.0.1 invalid? I believe this was not an issue previously.

honzajavorek picture honzajavorek on 20 Nov 2017
👍2

@honzajavorek Thanks for reporting, I'll have a closer look at the first one - looks like a bug.

✖   subject must not be sentence-case,start-case,pascal-case,upper-case [subject-case]
marionebl picture marionebl on 20 Nov 2017
👍3

I don't understand the first one. Why is the commit message chore(package): update @commitlint/config-angular to version 5.0.1 invalid? I believe this was not an issue previously.

I tried to update the config to the newest conventions as described in the Angular project and released this prematurely. (they forbid "chore" now)

I reset the latest tag to config-angular@4, so we should have some time now to sort this out.

marionebl picture marionebl on 20 Nov 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

texhnolyze picture texhnolyze  ·  3Comments
chris-dura picture chris-dura  ·  5Comments
kirillgroshkov picture kirillgroshkov  ·  3Comments
n0nick picture n0nick  ·  5Comments
juliuscc picture juliuscc  ·  3Comments