Codimd: Support for spell-check?

[orschiro]

Dear all,

Your tool is fantastic, thank you so much!

The only thing I am currently missing is the support for Chrome's built-in spell-check.

Is this something that you envision and that is technically possible?

Thankfully,

~Robert

[jackycute]

Hi, Robert!
Thanks for using!

It's technically possible to have the spell-check feature.
And that is a very useful feature that I always want HackMD to have.
But the HTML tag we are using now for the editor doesn't support built-in spell-check.
Even though we will do more research and seek more approaches for you and everyone.
So just leave this issue here and you will see the changes in the future!

😄

[orschiro]

Dear Max,

Thank you for your timely and positive response!

Please keep me in the pipe about the developments.

I am happy to test any next steps that bring us closer to having support for
spell-check in your wonderful editor! :-)

Thankfully,

~Robert

Sent from Nylas N1, the extensible, open source
mail client.

On Apr 12 2016, at 7:03 pm, Max Wu <[email protected]> wrote:

Hi, Robert!
Thanks for using!

It's technically possible to have the spell-check feature.
And that is a very useful feature I always want HackMD to have.
But the HTML tag we are using now for the editor doesn't support built-in
spell-check.
Even though we will do more research and seek more approaches for you and
everyone.
So just leave this issue here and you will see the changes in the future!

😄

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[jackycute]

I found something interesting:

https://github.com/NextStepWebs/codemirror-spell-checker
https://src.chromium.org/viewvc/chrome/trunk/deps/third_party/hunspell_dictionaries

And I believe you already know these resources.
I will try these out later.

[orschiro]

Dear Max,

Hunspell sounds good as it means that it will hopefully work flawlessly on
Linux. :-)

Thanks for your efforts!

~Robert

Sent from Nylas N1, the extensible, open source
mail client.

On Apr 12 2016, at 8:15 pm, Max Wu <[email protected]> wrote:

I found something interesting:

https://github.com/NextStepWebs/codemirror-spell-checker
naries>

And I believe you already know these resources.
And I will try these out later.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[jackycute]

I've tried that plugin and use the chromium dictionaries, result pretty good.
But it will overwrite other indicators (like: mark match word).
And it also apply on code block which is not needed.
So I need to rewrite that plugin, but things are going promising.

[orschiro]

Hi Max,

Promising progress!

This is not yet publicly testable, correct?

Warmly,

~Robert

Sent from Nylas N1, the extensible, open source
mail client.

On Apr 13 2016, at 5:03 am, Max Wu <[email protected]> wrote:

I've tried that plugin and use the chromium dictionaries, result pretty
good.
But it will overwrite other indicators (like: mark match word).
And it also apply on code block which is not needed.
So I need to rewrite that plugin, but things are going promising.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[jackycute]

Yes, it's not ready for now.
Maybe I'll make it as a experiment feature in these days.

[orschiro]

Maybe I'll make it as a experiment feature in these days.

Alright. Please let me know if I can be of use for something in the meantime.

~Robert

[jackycute]

Hi, Robert!
I made a note for spellcheck test:
https://hackmd.io/GYRgDAxgHAbAnAVgLRQCwENVNaqBTFAExGQCMp1h0I9y9hCg
Could you try it out?

[orschiro]

Hi Max,

Wow, thanks for your quick implementation!

Underlining is working. However, right mouse click context menu to show
correct suggestions does not work. :-(

See this screenshot:

https://cloud.githubusercontent.com/assets/170947/14553538/6db3245c-02e7-11e6-8af1-b89da70df453.png

Thankfully,

~Robert

[jackycute]

Hi, Robert,
Yeah, because it's not actually using the Chrome built spell-check function.
Because the ways to activate spell-check is limited, we have to do it by our own.
Also that's mean if we want to give the spell suggestion, we must build our own context menu.

Any advise is welcomed.

[orschiro]

> Also that's mean if we want to give the spell suggestion, we must build
our own context menu.

Interesting. I guess where are not the first ones facing this problem.

Maybe there are other parties we can team up with to build our own context
menu collaboratively together?

~Robert

Sent from Nylas N1, the extensible, open source
mail client.

On Apr 15 2016, at 3:39 pm, Max Wu <[email protected]> wrote:

Hi, Robert,
Yeah, because it's not actually using the Chrome built spell-check function.
Because the ways to activate spell-check is limited, we have to do it by our
own.
Also that's mean if we want to give the spell suggestion, we must build our
own context menu.

Any advises welcomed.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[jackycute]

Maybe:
https://github.com/swisnl/jQuery-contextMenu
https://github.com/sydcanem/bootstrap-contextmenu

[orschiro]

Thanks for finding these!

The first one seems to be very actively developed.

But maybe it also goes beyond the scope of this project to have a proper
dictionary suggestion integration.

Red underline is already useful to easily identify misspelled word, with
manual thinking intervention followed. :-)

~Robert

[jackycute]

Hi Robert!
I think I would like to move the spellcheck feature from YAML metadata to editor status bar.
Because it seems like a user-oriented profile.

[orschiro]

Hi Max,

Can you show a screenshot example, please?

Thankfully,

~Robert

[jackycute]

I mean at the position of the red square on the below pic

[orschiro]

Ah, cool!

So users would be able to enable the spell-check from the below statusbar?

~Robert

[jackycute]

yes, totally

[orschiro]

Like it! :)

[jackycute]

Supported in 09fb1209678b2acc18ee13ee0c407278e67d2c06

[orschiro]

Hey @jackycute,

Thanks a lot for eventually implementing it! :+1:

Warmly,

~Robert

[evok3d]

Thank you so much. I love your tool and was hoping to find a solution for a spell check. Now i see you have it ready to go! :D

[banderlog]

Anyone could switch spellchecking languages or everyone stick to default english?

[Yukaii]

Hi @banderlog We use codemirror-spell-checker and it only supports english now. Could you open a seperate issue for tracking multi-language spellcheck support?

[AlexWayfer]

@Yukaii not needed, it already exists: https://github.com/hackmdio/codimd/issues/647

[banderlog]

@Yukaii , @AlexWayfer thank you, guys