Code-settings-sync: Extension host killed

[wesleycoder]

🐛 Describe the bug
After the last update of VSCode (1.33.0), code-settings-sync is killing the Extension Host.

🌴 Visual Studio Code Version : 1.33.0
🌴 Code Settings Sync Version : 3.2.8
🌴 Standard or Insiders : Standard
🌴 OSS or Portable : Neither
🌴 Operating System : MacOS Mojave
🌴 Occurs On: Startup
🌴 Proxy Enabled: No
🌴 Gist Id: 8a8afe3f5b1388e1ee949020690bd2f9

📰 To Reproduce
Start VSCode.

💪 Expected behavior
Extension should sync normally.

📺 Console Error Log
Log from VSCode's DevTools:

dyld: lazy symbol binding failed: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorENS_14SideEffectTypeE
  Referenced from: /Users/wescoder/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node
  Expected in: flat namespace

dyld: Symbol not found: __ZN2v816FunctionTemplate3NewEPNS_7IsolateEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEENS_5LocalIS4_EENSA_INS_9SignatureEEEiNS_19ConstructorBehaviorENS_14SideEffectTypeE
  Referenced from: /Users/wescoder/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node
  Expected in: flat namespace


extensionService.ts:450 Extension host terminated unexpectedly. Code:  null  Signal:  SIGKILL
_onExtensionHostCrashed @ extensionService.ts:450
notificationsAlerts.ts:40 Extension host terminated unexpectedly.

Let me know how else can I help with this.

[shanalikhan]

code-settings-sync is killing the Extension Host.

can you post the image screen shot ? How you know Settings-Sync is killing host ?

[wesleycoder]

I've disabled all extensions, so the error got away, and enabled one by one and restarted between each until the error showed up again, and Sync was who caused it. Later today I'll post a screenshot.

[wesleycoder]

Here it is, I've disabled all other extensions.

VSCode version:

Sync version:

[shanalikhan]

@arnohovhannisyan

I think same issue happened previously due to which chokidar was removed from Settings Sync.
Can you look into this ?

Reference :
https://github.com/shanalikhan/code-settings-sync/issues/762
https://github.com/Microsoft/vscode/issues/68024#issuecomment-461379608
https://github.com/shanalikhan/code-settings-sync/pull/807

[wesleycoder]

I've run npm un -g fs-extra fs-events and didn't help.
Is there any other steps related to #762 that you would recommend to do? Should I reinstall VSCode?
I'll be watching Microsoft/vscode#68024 for any updates too.

Thanks for the support so far :)

[glossnyx]

I'm currently running v3.2.8 on macOS High Sierra with VS Code v1.33.0, but I'm not seeing any problems, and everything's working for me.

[glossnyx]

If anyone is still having trouble, I can send a PR that temporarily disables the use of fsevents on macOS until this issue is fixed.

[fev4]

Having the same issue. Pinpointed it the same way @wescoder did. Here's a screenshot of the error:

MacOS: 10.14.4
MacBook Pro Late 2013
VSCode: 1.33.0
Sync: 3.2.8

[glossnyx]

I'm thinking this issue might be Mojave-specific as I didn't encounter this on High Sierra. I'll send a PR disabling the use of fsevents which will temporarily fix it.

[fev4]

That could also be a reason. I just recently upgraded to the 10.14.4 update. Although totally unsure on how to pin point the problem if it is in that direction.

[glossnyx]

If you know how to build the extension from source, you can try testing my new experimental fix on Mojave.

[nekonenene]

@arnohovhannisyan
I tested chokidar-fix branch, but the error occured... 😢

Visual Studio Code: 1.33.0
macOS: 10.14.4

[glossnyx]

Ok, I guess we might have to find some other solution until this is fixed. Thanks for testing!

[glossnyx]

@nekonenene can you try clearing npm/yarn cache and then trying again without my fix? Fsevents was updated in v2.1.0 of chokidar, but maybe npm/yarn is using the old version from cache.

Edit: also try uninstalling fsevents and fsextra globally

[nekonenene]

@arnohovhannisyan

Thanks, I tried again. But, it still not works... The same error occurred.

commands:

rm -rf node_modules
npm cache clean --force
npm i
vsce package
code --install-extension code-settings-sync-3.2.8.vsix --force

[glossnyx]

@nekonenene What node version are you using?

[nekonenene]

@arnohovhannisyan
Node.js v10.15.3.(latest LTS)
It occurs with also v8.15.1.

[glossnyx]

@nekonenene I think I may have found a solution. https://github.com/ritwickdey/vscode-live-server/commit/ca594e49635f2ef6f921ff4dd99df1a275bb3d7d

[glossnyx]

@nekonenene Can you test my newest changes to the chokidar-fix branch? (you may have to use Yarn)

[nekonenene]

Phew,,, I'm getting tired. 😷

git pull
rm -rf package-lock.json yarn.lock node_modules
yarn
vsce package
code --install-extension code-settings-sync-3.2.8.vsix --force

And, I got the same error....
I would be grateful if you think much.

[glossnyx]

@nekonenene Sorry for wasting your time. Thank you for testing anyway!

[Spacebody]

I encountered the same issue. We encountered such a problem previously so quickly I disable this extension, and the problem is gone.

OS: Mojava 10.14.3
VS code: 1.33.0
Sync: 3.2.8

[glossnyx]

Everyone who's having this issue seems to be running Mojave. Is anyone having this issue in High Sierra or below?

[glossnyx]

Can anyone still having this issue try running these commands and trying again?

npm un -g fsevents fs-extra
npm cache clean --force

[wesleycoder]

I've already done this before and the problem persists, should I do it
again now?

My node version is 11.13.0

Em dom, 7 de abr de 2019 13:31, Arno Hovhannisyan [e-mail]
escreveu:

Can anyone still having this issue try running this command and trying
again?

npm un -g fsevents fs-extra

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shanalikhan/code-settings-sync/issues/827#issuecomment-480607493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV4go-u4GsNG_g_he7PK78se1IuiO5x4ks5veh1-gaJpZM4cd4-x
.

[glossnyx]

@wescoder If you've already tried, then no.

[glossnyx]

@wescoder Can you try installing this version of the extension?

https://cdn.discordapp.com/attachments/549007146868539408/564493848777064462/code-settings-sync-3.2.8.vsix

[Spacebody]

@arnohovhannisyan Wow, it works on my computer.

OS: Mojava 10.14.4 (updated today)
VS code: 1.33.0

[glossnyx]

@Spacebody Thanks! After further testing, I'll send a PR with the updated changes.

[wesleycoder]

@wescoder Can you try installing this version of the extension?

https://cdn.discordapp.com/attachments/549007146868539408/564493848777064462/code-settings-sync-3.2.8.vsix

@arnohovhannisyan It worked for me too! 🎉 😃 👍 🚀 :shipit:

I'm glad we could help.

[glossnyx]

Just opened a new PR with the changes. I hope this gets merged soon!

[shanalikhan]

Sweet!
Thanks, I will release the new version in a few days.

[NayaStudio]

on High Sierra it works, on Mojave it run into problems as described above (i don't apply this modified extension posted by @wescoder, i have 3.2.8)

[jamie1192]

@arnohovhannisyan yeah i'm gonna be that guy.. i'm on High Sierra having the same issue with VSCode 1.33.0 so it's not isolated to just Mojave..

[glossnyx]

Have you tried the fix I linked a few comments ago?

[jpgls]

Just to let you know - the fix in the version at: https://cdn.discordapp.com/attachments/549007146868539408/564493848777064462/code-settings-sync-3.2.8.vsix - works for me as well (woohoo) since I don't see anyone else with my system so far

macOS Sierra - 10.12.6
VSCode - 1.33.0
Node - 10.15.3

Thanks so much for the quick fix and the awesome extension!

[glossnyx]

@jpgls I'm glad it worked for you :). The fix should be merged into the official release in a few days.

[Spacebody]

You guys can temporally use the fixed version these days, and I hope the official release can use a new version number so that we can upgrade to the official version as usual.

[wesleycoder]

I'll take on this tomorrow and let you know if it works.

Em seg, 8 de abr de 2019 20:24, Arno Hovhannisyan [e-mail]
escreveu:

@wescoder https://github.com/wescoder I know that this issue has been
fixed already, but I was wondering if maybe you can test this version and
see if it crashes. I want to find out which version of chokidar broke it on
mac.

https://cdn.discordapp.com/attachments/549007146868539408/564953595892727853/code-settings-sync-3.2.8.vsix

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shanalikhan/code-settings-sync/issues/827#issuecomment-481043243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV4gowb2UcpGvxSP-aRItzeGSGUbJsaUks5ve8-bgaJpZM4cd4-x
.

[glossnyx]

Thanks!

[timgavin]

VSCode: 1.33.1
Mojave: 10.14.4
Settings Sync: 3.2.8

Still crashing :/

[glossnyx]

@timgavin Have you tried this?
https://cdn.discordapp.com/attachments/549007146868539408/564493848777064462/code-settings-sync-3.2.8.vsix

[timgavin]

@arnohovhannisyan I'm new to VSCode; what do I do with that?

[glossnyx]

@timgavin Go to the Extensions activity (the place where you install extensions), click the 3 dots on the top right, and click install vsix. Then choose the file I linked. This is a temporary solution until it is officially released.

[timgavin]

Tried it; still crashing.

[glossnyx]

@timgavin Try closing and reopening vscode. The message that the extension has been installed is still there, which means you haven't restarted vscode.

[timgavin]

I've restarted it a number of times (24 actually) while testing this and always receive that message if the extension is enabled. I installed the .vsix file, received that error message, restarted, and again received that error message.

I then disabled all extensions, restarted Code, enabled Settings Sync, received the error, restarted Code and received the error again. So, no extension conflict either.

EDIT: I'm using node v10.15.1. Could that be an issue?

[glossnyx]

@timgavin Can you post your console error log? You can get to it by going to Help -> Toggle Developer Tools on the menu bar.

Edit: node version shouldn't matter unless it's below 8

[timgavin]

@arnohovhannisyan

[glossnyx]

@timgavin That's weird. We've migrated away from fsevents on that version of the extension, so there shouldn't be any issues with fsevents.

Can you try running this?

npm un -g fsevents

Or

yarn global remove fsevents

[timgavin]

Ran npm un -g fsevents, restarted Code, problem persists.

Edit: received this after running command: up to date in 0.05s FWIW

Ran yarn global remove fsevents and received -bash: yarn: command not found

Uninstalled extension; restarted Code; reinstalled extension from file; restarted Code; error persists.

[wesleycoder]

@arnohovhannisyan Sorry for the late reply (I've been switching jobs this month).
My last attempt using https://cdn.discordapp.com/attachments/549007146868539408/564953595892727853/code-settings-sync-3.2.8.vsix was successfull and it works propperly.
If you want me to test other changes let me know.

[shanalikhan]

its fixed in v3.2.9