Code-settings-sync: Multi-line settings aren't ignored properly by sync

[connorshea]

🐛 Describe the bug
When using the new per-platform sync feature, settings that run for more than one line aren't commented-out properly.

🌴 Visual Studio Code Version : Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850)
🌴 Code Settings Sync Version : 3.2.0
🌴 Standard or Insiders : Standard
🌴 OSS or Portable : neither?
🌴 Operating System : macOS Mojave 10.14.0
🌴 Occurs On: Download
🌴 Proxy Enabled: No

📰 To Reproduce
Steps to reproduce the behavior:

1. Have VS Code with sync set up on two different machines (can be the same OS, just use the host option instead of os), we'll call them Machine A and Machine B.
2. Create a user settings file on Machine A (in my case, Mac) like so:

{
  // @sync os=mac
  "editor.quickSuggestions": {
    "other": true,
    "comments": true,
    "strings": true
  }
}

1. Sync the settings file to Machine B (Windows for me)
2. This is what you'll end up with on Machine B:

{
  // @sync os=mac
  // "editor.quickSuggestions": {
    "other": true,
    "comments": true,
    "strings": true
  }
}

💪 Expected behavior
The setting should be properly commented-out on Machine B.

{
  // @sync os=mac
  // "editor.quickSuggestions": {
  //  "other": true,
  //  "comments": true,
  //  "strings": true
  // }
}

[shanalikhan]

Thanks! Will look into it.

@ioprotium
One more to go :smile:

[protium-dev]

I will add that tomorrow! PR to 3.2.1 right?

[shanalikhan]

Yes, currently settings sync stands at v3.2.0

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Brian Mayo [e-mail]
Sent: Thursday, November 1, 2018 9:50:25 PM
To: shanalikhan/code-settings-sync
Cc: Shan Khan; Comment
Subject: Re: [shanalikhan/code-settings-sync] Multi-line settings aren't ignored properly by sync (#701)

I will add that tomorrow! PR to 3.2.1 right?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/shanalikhan/code-settings-sync/issues/701#issuecomment-435102272, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIXjnCj2nuQqUxBA3SlXRep-rrw9MqpDks5uqyZRgaJpZM4YAZlh.

[shanalikhan]

@ioprotium any update on this? :)

[protium-dev]

@shanalikhan Sorry for the delay. Yes I changed the code that parses the settings, I didn't contemplate the case for multi line settings, my bad. I will test on my environment and then drop the PR

[shanalikhan]

No problem - Thanks - Looking forward :)

[shanalikhan]

Fixed in v3.2.5
@connorshea

[connorshea]

Thanks!