Code-server: Env var PASSWORD is not honored in v3.7.1

[pallxk]

• uname -a: Linux arch2011 5.9.6-arch1-1 #1 SMP PREEMPT Thu, 05 Nov 2020 21:00:46 +0000 x86_64 GNU/Linux
• code-server --version: 3.7.1 2bf91ff6a6d1f29a8a93f97684177ccf5388cf34

Environment variable PASSWORD is not honored any more in code-server v3.7.1:

$ PASSWORD=abcdefg code-server
[2020-11-17T00:18:41.502Z] info  code-server 3.7.1 2bf91ff6a6d1f29a8a93f97684177ccf5388cf34
[2020-11-17T00:18:41.506Z] info  Using user-data-dir ~/.local/share/code-server
[2020-11-17T00:18:41.515Z] info  Using config file ~/.config/code-server/config.yaml
[2020-11-17T00:18:41.516Z] info  HTTP server listening on http://127.0.0.1:8080
[2020-11-17T00:18:41.516Z] info    - Authentication is enabled
[2020-11-17T00:18:41.516Z] info      - Using password from ~/.config/code-server/config.yaml
[2020-11-17T00:18:41.516Z] info    - Not serving HTTPS

Compared to v3.6.2:

$ PASSWORD=abcdefg code-server
[2020-11-17T00:20:34.807Z] info  Using user-data-dir ~/.local/share/code-server
[2020-11-17T00:20:34.812Z] info  code-server 3.6.2 9bde62fbd611a7a91c5f327fa43e0d06f1379169
[2020-11-17T00:20:34.813Z] info  Using config file ~/.config/code-server/config.yaml
[2020-11-17T00:20:34.817Z] info  HTTP server listening on http://127.0.0.1:8080
[2020-11-17T00:20:34.818Z] info      - Using password from $PASSWORD
[2020-11-17T00:20:34.818Z] info      - To disable use `--auth none`
[2020-11-17T00:20:34.818Z] info    - Not serving HTTPS

Content of config.yaml is auto generated:

$ cat ~/.config/code-server/config.yaml
bind-addr: 127.0.0.1:8080
auth: password
password: 28cc3d30b23383e05b070ea0
cert: false

Even if I delete config.yaml manually and then start code-server, it won't work as code-server will auto generate the config again.

[2020-11-17T00:17:13.039Z] info  Wrote default config file to ~/.config/code-server/config.yaml

[code-asher]

Thank you for the report, will fix asap.

[nhooyr]

Dealt with in #2334
Will be in the next release.