Code-server: Delete doesn't actually delete

[nol166]

• code-server version: v1.604-vsc1.32.0
• OS Version: macOS 10.14.4 (18E226)

Description

Deleting files from the file tree inside the IDE doesn't actually delete them from disk. It seems to simply remove them from the workspace until code-server is restarted

Expected Files should be sent to the trash/recycle bin

Steps to Reproduce

1. Run code-server
2. Right click on a file/folder
3. Choose delete
4. Check the local filesystem for that file/folder

[ghost]

also on Mac, and does not work.

[Egoscio-zz]

@nol166 One part of your issue mentions the IDE doesn't actually delete them from disk while the other mentions Files should be sent to the trash/recycle bin. I personally interpret those two statements as different things. code-server is technically sending files to its equivalent of a trash/recycle bin (the .Trash-1000 folder), but it's not deleting the files immediately from disk. That's because code-server abides by your settings for Files: Enable Trash, which by default is set to true. If you set files.enableTrash to false, code-server will immediately delete the file.

[code-asher]

Looks like trash depends on macos-trash (only when on a Mac obviously) so I suppose we'll want to bundle and extract that with the binary the way we do with ripgrep.

[yyynnn]

This happens on centos as well. Delete file then refresh fs -> boom file still in the directory

rm file works