Code-server: Zooming doesn't work

Created on 14 Mar 2019 · 7Comments · Source: cdr/code-server

code-server version: v1.32.0-245
OS Version: Ubuntu 16.04

Description

Zooming doesn't work either using the hotkeys (e.g. ctrl+=) or through the command palette (e.g. View: Zoom In). Is this expected behavior? I didn't see it documented anywhere, though I've only just started testing out this project, so I assume it's a bug. If some limitation of running VS Code this way makes it hard/impossible to support zooming, is there a good workaround to make everything smaller/larger?

(This, and hotkeys being used for Chrome things instead of VS Code things, are the only discrepancies I've had so far in reproducing my local setup - thanks for the nice work! EDIT - being full screen changes the effect of the keyboard shortcuts? At least one shortcut that Chrome intercepted previously was used as I expected by VS Code. Though I can't seem to go fullscreen when focused on the tab with code-server's VS Code in it. But I digress..)

Steps to Reproduce

Run code-server
Try to zoom in/out.

bug

Source

neighthan

Most helpful comment

Confirming this issue on latest release. I think this is highly dependent on Electron API.

sr229 on 14 Mar 2019

👍2

All 7 comments

Confirming this issue on latest release. I think this is highly dependent on Electron API.

sr229 on 14 Mar 2019

👍2

We _can_ do this with CSS, but not actually adjust the zoom levels of the browser, unfortunately.

kylecarbs on 14 Mar 2019

Closing as there isn't a great solution for this.

kylecarbs on 17 Mar 2019

Actually, we should just disable the zoom commands.

kylecarbs on 17 Mar 2019

@kylecarbs From what I can see, this seems to be manipulating the zoom in Electron, so I believe we should omit it entirely.

sr229 on 17 Mar 2019

👍1

While waiting for pull request to merge, you can add this to your keybindings so that browser action can take over. the "-" in front of the command seems to disable it.

[
    { "key": "ctrl+shift+=",          "command": "-workbench.action.zoomIn" },
    { "key": "ctrl+=",                "command": "-workbench.action.zoomIn" },
    { "key": "ctrl+numpad_subtract",  "command": "-workbench.action.zoomOut" },
    { "key": "ctrl+-",                "command": "-workbench.action.zoomOut" },
]

jots on 9 May 2019

Hope that can be addressed soon:-) Before that, the workaround mentioned above seems to have some limitation. After I modify the keybindings.json as above in User directory. I do not see zoom is working until I put the focus somewhere out of the editor... e.g. the browser address bar... it seems the short cuts will be absorbed/captured by vscode editor... which is not expected...

@jots @kylecarbs