Cockatrice: add card filter based on cards already in deck

[GatesDA]

Edit for clarity: Have an card filter that checks whether cards are already in the deck or not. This would be particularly useful inverted ("NOT in deck") for formats like Commander with large decklists.

[tooomm]

I don't quite get this. :)

Do you suggest a second area to have filters that only apply to your deck?
Do you talk about a search bar on top of your deck?
...

Can you please explain a little bite more what your idea is and how you think it should be implemented?

[GatesDA]

I was thinking an option in the normal filter area, in the same dropdown as "CMC", "Power", "Type", and so forth. So I might put "AND NOT In deck" alongside my other filters while building a Commander deck so cards I've already added don't show up in the search results. Or I might pair "AND In deck" with "Text AND destroy AND artifact" to check what artifact removal I have.

The implementation would have to be a bit of a special case since none of the other filters are simple yes/no properties. Disabling the "Type your filter here" textbox when "In deck" is selected, for instance.

[ZeldaZach]

Dupe #3741 (yes, I know this is older but we're backtracking)

[GatesDA]

This isn't the same as #3741. That one is for filtering the decklist, this one is for filtering by whether or not a card's in the decklist. There's no overlap in functionality.

[ebbit1q]

please elaborate, filtering whether or not a card is in the decklist sounds like a subset of filtering the decklist to me.

[tooomm]

As I understand it... one further narrows the results of your search in deck editor.
The other searches your deck for a certain card or filters for e.g. a certain cmc.

The first would be to search for red cards of type goblin but minus the ones already in your deck.
The second would be to make sure if goblin king is already in your deck list or how many five drops you have.

[ebbit1q]

hmm, no it simply asks to use the main card filter input box to filter the decklist as well, adding a filter for if a card is already in your decklist sounds like a great idea though, do we already have a ticket for that?

[ebbit1q]

if you have any further suggestions on how to make the user experience for filtering the decklist better please comment on the open ticket instead of this one.

[tooomm]

hmm, no it simply asks to use the main card filter input box to filter the decklist as well,

@ebbit1q that's how i understand his explains of his request a few comments above at least: https://github.com/Cockatrice/Cockatrice/issues/3403#issuecomment-700984296

Reopen this one then (as i'm not aware of another ticket), but rename it?

[ebbit1q]

maybe add those suggestions to https://github.com/Cockatrice/Cockatrice/issues/3763

[tooomm]

I don't see how this is connected as #3763 asks for additional columns in the deck widget.
It wants to to display more information about the cards in your deck list:

While this ticket here asks for a new filter to search all card list in the deck editor:

[ebbit1q]

this ticket is identical to #3741 then, please note that there is no real distinction between the filters in this widget and the search bar, they are two interfaces to the same functionality.

[GatesDA]

hmm, no it simply asks to use the main card filter input box to filter the decklist as well, adding a filter for if a card is already in your decklist sounds like a great idea though, do we already have a ticket for that?

"A filter for if a card is already in your decklist" is exactly what I was asking for (hence the title of this ticket), and I spelled it out in an additional comment two years ago. I can see where the confusion crept in, though, since there's some functionality overlap with filtering the decklist and I mentioned that use case in the ticket. I updated the main ticket to be clearer about the intent.

[ebbit1q]

thank you!