Cockatrice: capitalization of files in install directory

Created on 21 May 2017  路  5Comments  路  Source: Cockatrice/Cockatrice

OS:
Win 10

Cockatrice version:
Version 2.3.18-custom_f0a561d (2017-05-20)


Referring to #2412, the exe binaries on win aren't properly capitalized.
Same problem with mac: https://github.com/Cockatrice/Cockatrice/issues/3235#issuecomment-388072892

naming
(also leads to lower case shortcuts if you right click and create one)

Also, our folders in the installation directory are not treated uniformly. Plugins is capitalized, while all others are lower case...
In the user directory we have all folders in lower case as well - so plugins?

Cleanup Good first issue

Most helpful comment

It's typical for windows and osx to have them capitalized. It looks out of place and weird lowercased. And it doesn't hurt anything to fix them.

All 5 comments

Changing Plugins to plugins would be nice, as lowercase is always better especially for certain linux systems.

I assume it's the same on other operating systems

In linux/unix executables are always lowercase. So yes, this is the case. Do the windows executables need to be capitalized for something in particular?

It's typical for windows and osx to have them capitalized. It looks out of place and weird lowercased. And it doesn't hurt anything to fix them.

Ah, I never use windows or osx so I wouldn't have known.

This would just be a difference in the build of the program, at least for the executables, right? The only thing in the actual source would be the folder.

That sounds about right, yes. It's mostly going to be cmake config changes.

This would break existing installs, not worth imo

Was this page helpful?
0 / 5 - 0 ratings