Coala: Public API broken by PR 4240

Created on 22 Jul 2017  路  6Comments  路  Source: coala/coala

coala/coala#4240 broke coala-quickstart.

It removed public API functions

  • coalib.settings.ConfigurationGathering.get_filtered_bears (replacing it with get_all_bears) and
  • coalib.collecting.Collectors.filter_section_bears_by_languages

This needs to be fixed, or reverted.

cc @satwikkansal

importanccritical regression typbug
Source
picture jayvdb

All 6 comments

Definitely fixed, no reverted.

filter_section_bears_by_languages can be replaced with

local_bears, global_bears = FilterHelper.get_filtered_bears(
    'language', ['language1', 'language2', ...])
Makman2 picture Makman2 on 22 Jul 2017

This has also broken the docker:
https://travis-ci.org/jayvdb/docker-coala-base/builds/256362638#L9177

@yash-nisar

jayvdb picture jayvdb on 22 Jul 2017

@Makman2 , this was part of a public API. It shouldnt be broken; that breaks other peoples projects, which two days before a GSOC end of phase is quite serious. Please can we patch coala to restore it?

jayvdb picture jayvdb on 22 Jul 2017

Hmm I haven't considered those functions being public API...

Okay let's revert, we implement compatability functions with deprecation notes :+1:

Makman2 picture Makman2 on 22 Jul 2017
👍1

CC @shreyans800755

Makman2 picture Makman2 on 22 Jul 2017

Thank you @jayvdb for fixing it quickly :)

satwikkansal picture satwikkansal on 23 Jul 2017
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

paniabhisek picture paniabhisek  路  6Comments
jayvdb picture jayvdb  路  6Comments
meetmangukiya picture meetmangukiya  路  4Comments
userzimmermann picture userzimmermann  路  4Comments
ishanSrt picture ishanSrt  路  3Comments