Coala: Diff: deletion stats can be incorrect
Since out of range deletions are allowed, the stats that will be created are incorrect
In [1]: from coalib.results.Diff import Diff
In [2]: a = Diff(['1', '2'])
In [3]: a.delete_lines(2,10)
In [4]: a.modified
Out[4]: ['1']
In [5]: a.stats()
Out[5]: (0, 9)
Is this an intended behavior?
meetmangukiya
All 4 comments
hm looks indeed wrong...
Makman2
on 27 Feb 2017
Should out of range deletion be allowed?
Techievena
on 1 Mar 2017
No, it shouldn't be, thats what this issue is about
meetmangukiya
on 1 Mar 2017
👍2
No I was bit confused about if file_list contains fragment of a file. Nvm figured out I was wrong. :sweat_smile:
Techievena
on 1 Mar 2017
Was this page helpful?
0 / 5 - 0 ratings
Related issues
jschwarzwalder
路
6Comments
yash-nisar
路
3Comments
userzimmermann
路
3Comments
coala-bot
路
4Comments
userzimmermann
路
4Comments
Most helpful comment
No, it shouldn't be, thats what this issue is about