Cms: Contains modifier should support Collections

[jonassiewertsen]

{{ if items | contains:sellable:false }}

WIth the given data, I would expect to get false returned.

I am getting true instead.

A link to the docs:
https://statamic.dev/modifiers/contains

Environment

Statamic version: 3.0.0.-beta-37

PHP version: 7.4

[jonassiewertsen]

The problem might be, that I am passing a collection.

[duncanmcclean]

What if you convert it to json and then check if it contains sellable, like this:

{{ if items | to_json | contains:sellable:false }}

[jonassiewertsen]

Cool idea!

Not working though.

[duncanmcclean]

If it's a Laravel collection (Illuminate\Support\Collection) you're talking about, what about if you convert it to an array before passing to your view/tag? Then try the to_json thing.

[jonassiewertsen]

That should work.

To keep a clean syntax, I will go with a custom modifier.

{{ unless items | sellable }}
   Some text           
{{ /unless }}

My modifier simply says:

return ! $value->contains('sellable', false);

[jasonvarga]

That modifier should support collections. I'll change the subject for you.

[jackmcdade]

Actually, this is more of a task for the where modifier. This will work:

{{ if items | where:sellable }}