Cluster-api: Remove the DeleteNodeAnnotation (deprecated) annotation

Created on 30 Nov 2020 · 6Comments · Source: kubernetes-sigs/cluster-api

The following annotation has been deprecated in an earlier version, and should be removed entirely in v1alpha4

https://github.com/kubernetes-sigs/cluster-api/blob/2dd66d6e1559f47302c263cd75bd20265ce6403a/controllers/machineset_delete_policy.go#L34-L37

/kind cleanup
/milestone v0.4.0
/good-first-issue

good first issue help wanted kincleanup lifecyclactive prioritimportant-longterm

Source

vincepri

All 6 comments

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

The following annotation has been deprecated in an earlier version, and should be removed entirely in v1alpha4

https://github.com/kubernetes-sigs/cluster-api/blob/2dd66d6e1559f47302c263cd75bd20265ce6403a/controllers/machineset_delete_policy.go#L34-L37

/kind cleanup
/milestone v0.4.0
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.