Cluster-api: node deletion can't delete node

Created on 21 Jun 2019  路  4Comments  路  Source: kubernetes-sigs/cluster-api

/kind bug

It might be my misunderstanding, but deleting a node doesn't make sense. The machine actuator has a client to the management cluster, but, unless I'm misunderstanding what 'node' means here, it has no way to delete the node object from the target cluster. What node object is cluster-api trying to delete? I'm specifically referencing https://github.com/kubernetes-sigs/cluster-api/blob/master/pkg/controller/machine/machine_controller.go#L277 this code.

Perhaps it's special code only meant to manage nodes on the management cluster and the provider must manage removal of nodes from target cluster?

aremachine kinbug lifecyclactive prioritimportant-soon
Source
picture chuckha

All 4 comments

The assumption in the code you linked is that there is only one cluster, performing the roles of management cluster and workload cluster, together. With the work that @vincepri has been doing to support remote node references, this will need to be adjusted. And that's what he's done in #1052 馃槃 (not merged yet)

ncdc picture ncdc on 21 Jun 2019
👍1

/assign @vincepri
/milestone v1alpha2
/priority important-soon
/area machine

ncdc picture ncdc on 21 Jun 2019

/lifecycle active

ncdc picture ncdc on 21 Jun 2019

haha trust @vincepri to solve my problems before I know I have them

chuckha picture chuckha on 21 Jun 2019
😄1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

oneilcin picture oneilcin  路  6Comments
fabriziopandini picture fabriziopandini  路  3Comments
fabriziopandini picture fabriziopandini  路  5Comments
detiber picture detiber  路  5Comments
timothysc picture timothysc  路  6Comments