Cluster-api: KCP may have extraneous RBAC roles

Created on 4 Aug 2020  路  6Comments  路  Source: kubernetes-sigs/cluster-api

What steps did you take and what happened:
[A clear and concise description on how to REPRODUCE the bug.]
The roles specified for KCP here might not be needed
https://github.com/kubernetes-sigs/cluster-api/blob/69347982dc6983615cd439e975cccb397083859e/controlplane/kubeadm/config/rbac/role.yaml#L68

These roles are not used

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version: v0.3.8
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

kinbug prioritimportant-soon
Source
picture DheerajSShetty

All 6 comments

@sedefsavas Can you investigate + triage?

vincepri picture vincepri on 4 Aug 2020

Yes, I am looking into this.

sedefsavas picture sedefsavas on 4 Aug 2020
👍1

/priority awaiting-more-evidence
/milestone Next

vincepri picture vincepri on 4 Aug 2020

These are unused rbac rules added to control plane. I don't think removing them will affect anything. Have a PR open, I think it can go in v0.3.9.

sedefsavas picture sedefsavas on 5 Aug 2020

/milestone v0.3.9
/cc @detiber

vincepri picture vincepri on 5 Aug 2020

+1 to removing these rules
/priority important-soon

detiber picture detiber on 5 Aug 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ncdc picture ncdc  路  5Comments
vincepri picture vincepri  路  4Comments
vincepri picture vincepri  路  4Comments
detiber picture detiber  路  5Comments
bgoareguer picture bgoareguer  路  5Comments