Cluster-api: Remove deprecated DeleteNodeAnnotation

[wfernandes]

We've marked DeleteNodeAnnotation for deprecation as part of this PR https://github.com/kubernetes-sigs/cluster-api/pull/2929.

This issue is to track its removal.

/kind cleanup
/milestone v0.4.0

[k8s-ci-robot]

@wfernandes: You must be a member of the kubernetes-sigs/cluster-api-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

We've marked DeleteNodeAnnotation for deprecation as part of this PR https://github.com/kubernetes-sigs/cluster-api/pull/2929.

This issue is to track its removal.

/kind cleanup
/milestone v0.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/milestone v0.4.0

[detiber]

@elmiko this will have implications for the cluster autoscaler integration

[elmiko]

thanks for the heads up @detiber, it certainly will!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[elmiko]

i think this is still active, maybe someone can correct me if that's not the case.
/remove-lifecycle stale

[detiber]

Indeed, this is still applicable
/lifecycle frozen