Cluster-api: Refactor MachineSet reconciler to be consistent with Cluster and Machine patterns

Created on 30 Oct 2019 · 8Comments · Source: kubernetes-sigs/cluster-api

We rewrote the Cluster and Machine controllers in v1alpha2 using new patterns and conventions. For example, we use a defer statement with our patch helper to ensure the object being reconciled is always patched to persist whatever changes we made when reconciling.

We should update the MachineSet reconciler to follow these patterns.

/priority important-longterm
/kind cleanup

help wanted kincleanup lifecyclactive prioritimportant-longterm

Source

ncdc

All 8 comments

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 5 Mar 2020

/lifecycle frozen

vincepri on 5 Mar 2020

/help

vincepri on 16 Oct 2020

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.