Cluster-api: ClusterClient should return controller-runtime client not static client

Created on 9 Sep 2019  路  7Comments  路  Source: kubernetes-sigs/cluster-api

/kind feature

Describe the solution you'd like
It would be nice if ClusterClient was actually just controller-runtime's client.

Anything else you would like to add:
I think ClusterClient can go away in favor of client.Client.

Unless there is some reason we're using the typed client, of course.

kinfeature lifecyclactive prioritimportant-longterm

Most helpful comment

+1 to removing ClusterClient

All 7 comments

+1 to removing ClusterClient

I'm gonna grab this as it's blocking some work on cabpk side

/assign
/lifecycle active

FWIW, I thought you were referring to cmd/clusterctl/clusterdeployer/clusterclient so I was kinda surprised when the PR was as small as it was 馃榿

ah, yes, that one will have to wait i'm afraid

Hi @andrewsykim,

Please take note of this issue as it will affect a lot of the code you're writing in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/pull/502.

@chuckha says he doesn't need to make this change any more.
/close

@ncdc: Closing this issue.

In response to this:

@chuckha says he doesn't need to make this change any more.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings