Cluster-api: Code walkthrough

Created on 12 Jun 2019  路  12Comments  路  Source: kubernetes-sigs/cluster-api

Per-discussions during grooming, we are going todo a code walkthrough or audit.

The purposes of code walkthroughs is both to inform, but to also open issues on longstanding bugs, warts, etc in the code.

If folks have proposed times, please add them below otherwise I will send out a doodle.

prioritimportant-soon

Most helpful comment

I propose the Implementers Office Hours time slots _as options_. I see no reason to exclude them.

Tue 12pm PT (21:00 CET)
Wed 6am PT (15:00 CET)

All 12 comments

It would be great to put together some sort of rough agenda or ordering, so new folks like me can read ahead in an order that would be helpful.

Monday or Tuesday next week is probably better for me than the other days, although I can probably make anything work.

It would be great to put together some sort of rough agenda or ordering, so new folks like me can read ahead in an order that would be helpful.

Code walkthroughs are pretty ad hoc conversations where you have someone driving the code and others asking questions about why.

I propose the Implementers Office Hours time slots _as options_. I see no reason to exclude them.

Tue 12pm PT (21:00 CET)
Wed 6am PT (15:00 CET)

It would be great to put together some sort of rough agenda or ordering, so new folks like me can read ahead in an order that would be helpful.

Code walkthroughs are pretty ad hoc conversations where you have someone driving the code and others asking questions about why.

Presumably we wouldn't do that by picking files at random, though, right?

I would start by explaining the overall structure of the repo, in terms of API types, controllers, etc. I'd talk about the Manager first, then work my way into each controller.

I would start by explaining the overall structure of the repo, in terms of API types, controllers, etc. I'd talk about the Manager first, then work my way into each controller.

That's the sort of thing I'm looking for. But with some filenames for us n00bs. :-)

Folks want to add to the open capi-agenda a Code-Walkthrough section and we can use that as our guide?

/assign @timothysc @vincepri

@vincepri when you send out the invite feel free to close with deets.

Invite sent!

/close

@vincepri: Closing this issue.

In response to this:

Invite sent!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings