Cluster-api-provider-azure: [help wanted] refactor remaining services following established pattern

[CecileRobertMichon]

Following the pattern established in #716, we should refactor each service to follow the same pattern. Each service should have its own refactor PR to make reviewing easier. For example, network interfaces was already done in #742.

• [x] disks (@cpanato)

• [x] groups (@cpanato)

• [ ] exp/managedclusters

• [ ] exp/agentpools

• [x] public IPs (@CecileRobertMichon)

• [x] network interfaces (@CecileRobertMichon)

• [x] load balancers (@CecileRobertMichon)

• [x] subnets (@cpanato)

• [x] virtual networks (@cpanato)

• [x] route tables (@nader-ziada)

• [x] inbound nat rules (@CecileRobertMichon)

• [x] role assignments (@CecileRobertMichon)

• [x] resource skus (@alexeldeib)

• [x] securitygroups (@CecileRobertMichon)

• [x] exp/scalesets (@CecileRobertMichon)

• [x] virtualmachines (@CecileRobertMichon)

Let me know if you want to help with one of these in comments and I'll add your username next to it!

/help

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Following the pattern established in #716, we should refactor each service to follow the same pattern. Each service should have its own refactor PR to make reviewing easier. For example, network interfaces was already done in #742.

• [ ] disks

• [ ] groups

• [ ] exp/managedclusters (@devigned)

• [ ] exp/agentpools (@devigned)

• [ ] public IPs (@CecileRobertMichon)

• [ ] network interfaces (@CecileRobertMichon)

• [ ] load balancers (@CecileRobertMichon)

• [ ] subnets

• [ ] virtual networks

• [ ] route tables

• [ ] exp/scalesets (needs more work)

• [ ] virtualmachines (needs more work)

Let me know if you want to help with one of these in comments and I'll add your username next to it!

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cpanato]

Can I take disks?

[cpanato]

Can I take groups ?

[CecileRobertMichon]

/priority important-soon

[cpanato]

@CecileRobertMichon can I take subnets?

[devigned]

@cpanato, go for it! I don't think anyone is working on it right now.

[cpanato]

ok, after the subnet i will take the virtual networks if that is fine

[cpanato]

going to work on virtual networks

[nader-ziada]

route tables is the last one without a name, I'll take that one

[CecileRobertMichon]

@alexeldeib changed resource skus to you since you have #783 open

[CecileRobertMichon]

/assign

[CecileRobertMichon]

/help

[CecileRobertMichon]

/milestone next

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[devigned]

/remove-lifecycle stale

[nader-ziada]

I can take that one after the existing "refactoring PRs" get merged

[nprokopic]

I can take exp/managedclusters and exp/agentpools.

[nader-ziada]

thanks @nprokopic

[nprokopic]

FYI I finally got to start with AKS refactoring (managed cluster and agent pools), started working on it this week.

[CecileRobertMichon]

/assign @nprokopic

[devigned]

/milestone v0.5.x