Copy paste from https://github.com/kubernetes-sigs/cluster-api/issues/4256
Cert manager version was recently bumped to v1.1.0 in this commit but the Tilt module wasn't updated.
There are a few changes that should be made in the module:
the workaround for https://github.com/jetstack/cert-manager/issues/3121 can be removed since the issue is now fixed
I might be missing some things, we should also audit commit to make sure no other changes are needed.
/help
/good-first-issue
@CecileRobertMichon:
This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/help
/good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/assign
Hi @CecileRobertMichon, as the task in Cluster API has been done and replicated in the tilt module too it would be nicer if we commit the same thing here.
FYI @fabriziopandini
yes let's implement the same changes as https://github.com/kubernetes-sigs/cluster-api/pull/4274
@enyinna1234 let us know if you have any questions
/close
fixed by #1234
@nader-ziada: Closing this issue.
In response to this:
/close
fixed by #1234
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
yes let's implement the same changes as https://github.com/kubernetes-sigs/cluster-api/pull/4274
@enyinna1234 let us know if you have any questions