Cluster-api-provider-azure: [managedcluster] e2e tests

[alexeldeib]

/kind feature

Describe the solution you'd like
We should add e2e tests similar to the existing tests for Azure, particularly being sure to validate the options we provide to AKS match the result we get.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[alexeldeib]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[CecileRobertMichon]

/remove-lifecycle stale
/help

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[CecileRobertMichon]

/remove-lifecycle stale

[alexeldeib]

couple observations from spiking on this.

The capi test framework is a bit tightly coupled. The machine portion is fairly well abstracted but the control plane tests hardcode a KubeadmControlPlane struct as part of the test context [0], [1]. Besides the fact that it uses KCP directly instead of the CAPI control plane contract, it also relies on a control plane provider using machines for the underlying implementation, which is not necessarily true. A control plane could be pod based or in the case of AKS/EKS/GKE fully managed/externalized.

It would be nice to decouple the pieces of the capi e2e framework to allow it to run against arbitrary control plane implementations like used for AzureManagedControlPlane. That seems like it might take a good chunk of work. A shorter term approach could be a simple pipeline which does the following:

• create AzureManagedCluster with clusterctl
• wait for all objects to reach status.ready = true
• validate control plane connectivity, ensure all nodes ready
• delete crds, ensure all objects get deleted (maybe verify against azure CLI at the end or something?)

[alexeldeib]

this should be unblocked / easier thanks to @shysank's upstream work, at least using v0.4.0-beta.0 or later of CAPI 🎉

[CecileRobertMichon]

@shysank is actually working on this in https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1386

[alexeldeib]

/assign @shysank

We can definitely add more configurations on top of the work in #1386, but marking as assigned since I feel that's enough to close the general issue for adding e2e. Let's open specific issues for desired testing scenarios after that gets merged.

[nader-ziada]

/close

fixed with e2e added as part of #1386 🚀

[k8s-ci-robot]

@nader-ziada: Closing this issue.

In response to this:

/close

fixed with e2e added as part of #1386 🚀

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.