Cluster-api-provider-azure: Add validations for AzureCluster Updates

[CecileRobertMichon]

Some fields (eg. Azure location) are immutable and we should fail when they are updated.

To get started, you can look at how we implemented validation for AzureMachines here:

https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/api/v1alpha3/azuremachine_webhook.go#L46

and add to https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/api/v1alpha3/azurecluster_webhook.go

You can also look at this PR in CAPA which achieves something similar: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/1677/files

[CecileRobertMichon]

/help

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jackfrancis]

/assign

[jackfrancis]

@CecileRobertMichon should we re-scope this issue to just the location property? If so, then #522 will close this. If not, then I'll note in #522 that we've made progress, but we'll keep this issue open.

[CecileRobertMichon]

@jackfrancis let's keep this one open and once #522 merges we can make a list of the other properties that should be validated as immutable in this issue for someone else to pick up.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[CecileRobertMichon]

/remove-lifecycle stale

[alexeldeib]

/remove-lifecycle rotten

[CecileRobertMichon]

/unassign @jackfrancis

[surajrana93]

@CecileRobertMichon do you need help in this?

[furkatgofurov7]

@surajrana93 have you picked this up already? if not I would like to work on this.

[CecileRobertMichon]

@furkatgofurov7 go for it, I believe @surajrana93 is already working on #1075

[furkatgofurov7]

/assign

[CecileRobertMichon]

Fields that we should allow updates on:

• AdditionalTags
• ControlPlaneEndpoint (this should be moving to status in v1alpha4 but we need to keep it updatable so the controllers can update it when the LB is provisioned)
• NetworkSpec.APIServerLB (this is to allow backcompat backfill)

Everything else should not be updated.

/cc @devigned