Client: Move to react-spring

Created on 17 Jul 2018  ·  24Comments  ·  Source: aragon/client

Replace react-motion with react-spring and make use of aragon-ui's new springs configurations.

enhancement good first issue

All 24 comments

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__This issue now has a funding of 0.4 ETH (82.58 USD @ $206.45/ETH) attached to it as part of the Aragon DAC fund.__

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


__Work has been started__.

These users each claimed they can complete the work by 3 months, 2 weeks ago.
Please review their action plans below:

1) mul53 has been approved to start work.

Hi,
I am good with react and worked with spring before will ensure a smooth move. I will get started right away

Learn more on the Gitcoin Issue Details page.

Hey @sohkai, i have made part of the changes and i want to test them in the browser but i am having trouble getting past the initial page, sorry for the trouble this is my first time using aragon.

Hi @mul53, the easiest way to test it locally is to run it against a rinkeby DAO. Assuming you're starting aragon/aragon locally (npm run start), you should be able to access localhost:3000/#/ngo.aragonid.eth.

What other problems are you having with the initial page (I'm assuming the start page, localhost:3000/)?

Thanks @sohkai , managed to get to the home page and yes it was the start page. It gives me apps loading error again is there something i didn't configure, again thanks for the help.

@sohkai i have changed all the components which were using react-motion to use react-spring with the config from aragon-ui is that all? and i could only test a few since i was getting a apps loading error, i can make the PR?

@mul53 It looks our rinkeby node (servicing the app) is down... In any case, please make the PR :).

It should be back up later so you can probably test things :).


Edit: please pull from master and try again :). We updated our node recently and hadn't reflected it on master.

@sohkai , i tried again and it failed. There is this commented code using react-motion should it be touched? I will make the PR as soon as you say what to do with this

https://github.com/aragon/aragon/blob/44581486cc4412a689a55d770190bc1a6a732cfa/src/components/MenuPanel/MenuPanel.js#L2

https://github.com/aragon/aragon/blob/44581486cc4412a689a55d770190bc1a6a732cfa/src/components/MenuPanel/MenuPanel.js#L109-L117

@mul53 Weird, you've pulled from master and ran npm run start?

It'd be nice if those lines were also moved over to use react-springs :).

@sohkai i have created the PR

hey @Quazia, Frank from Gitcoin here - it seems that @sohkai and @mul53 have started work on this issue. Is it possible for you to approve the workers and reject the ones that won't be working on the issue? https://gitcoin.co/issue/aragon/aragon/311/1571

@mul53 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mul53 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@mul53 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] warning (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mul53 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hey @sohkai, Ryan from Gitcoin checking in here. Looks like @bpierre will review the PR early next week; snoozing the bot 🌮 😄

@mul53 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mul53 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@mul53 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@mul53 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] reminder (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Hey @Quazia could you mark this bounty as done? Thanks!

⚡️ A tip worth 0.40000 ETH (71.45 USD @ $178.62/ETH) has been granted to @mul53 for this issue from @Quazia. ⚡️

Nice work @mul53! Your tip has automatically been deposited in the ETH address we have on file.

I had to do it as a tip since the work wasn't "submitted" I don't know what that entails but regardless should be paid now.

Frank from Gitcoin here, I've marked the issue as done.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ricburton picture ricburton  ·  3Comments

luisivan picture luisivan  ·  3Comments

john-light picture john-light  ·  3Comments

john-light picture john-light  ·  3Comments

john-light picture john-light  ·  3Comments