Cli: ☂️Umbrella: TypeScript migration

[thymikee]

Describe the Feature

Some time ago we started migrating CLI to TS package by package. The infrastructure is already set up, so we can work with TS and Flow files without issues.

Currently all packages except for packages/cli are converted. We need your help in converting the rest of the codebase 💪.

Work plan

If you'd like to help with migrating any of the packages mentioned below, please leave a comment and we'll assign it to you.

Commands

Commands live in separate directories. It makes sense to tackle them one by one.

• [x] commands/bundle (@Quadriphobs1)
• [x] commands/config (@netochaves)
• [x] commands/doctor (@thib92)
• [x] commands/info (@FLGMwt)
• [x] commands/init (@gvarandas)
• [x] commands/install (@DanielUche)
• [x] commands/link (@anikethsaha)
• [x] commands/server (@Esemesek)
• [x] commands/upgrade (@thymikee)
• [x] commands/index.js (@thymikee)

Tools

Tools are helpers we use throughout the cli package. They have corresponding test files, which can be found in commands/tools/__tests__ directory. Those should also be converted.

• [x] commands/tools/assertRequiredOptions.js (@konojunya)
• [x] commands/tools/assign.js (@radko93)
• [x] commands/tools/brewInstall.js (@thymikee)
• [x] commands/tools/config/ (@ptrocki)
• [x] commands/tools/copyAndReplace.js (@luizcieslak)
• [x] commands/tools/copyFiles.js (@sasurau4)
• [x] commands/tools/findSymlinkedModules.js (@pveyes)
• [x] commands/tools/generator/ (@KangYoosam)
• [x] commands/tools/gracefulifyFs.js (@assuncaocharles)
• [x] commands/tools/install.js (@thymikee)
• [x] commands/tools/installPods.js (@thymikee)
• [x] commands/tools/isValidPackageName.js (@radko93)
• [x] commands/tools/loadMetroConfig.js (@radko93)
• [x] commands/tools/loader.js (@thymikee)
• [x] commands/tools/merge.js (@Naturalclar)
• [x] commands/tools/packageManager.js (@moriyuu)
• [x] commands/tools/releaseChecker/ (@FLGMwt)
• [x] commands/tools/replacePathSepForRegex.js (@FLGMwt)
• [x] commands/tools/walk.js (@FLGMwt)
• [x] commands/tools/yarn.js (@FLGMwt)

Root index files in src/

Let's tackle this once we have all commands converted.

• [x] cliEntry.js, index.js, bin.js (@Esemesek)

[FLGMwt]

👋 Hey stranger ; D

I'm happy to give it a shot. I'd like to try to start with something small like commands/info. Could use some guidance about what to do about ConfigT from types which seems to be the only imported flow type.

[thymikee]

Hey! You can find shared types like Config, Command etc in @react-native-community/cli-types package.

[netochaves]

I would like to work in config if that's ok.

[thib92]

Would love to take the ˋdoctor` command!

[thymikee]

@netochaves @thib92 go for it!

[FLGMwt]

I was pulling the thread on tools/releaseChecker so I can pull that and replacePathSepForRegex + walk + yarn in too.

[gvarandas]

I can tackle the commands/init 🤖

[DanielUche]

I will like to tackle commands/install

[Naturalclar]

I'd like to help with commands/tools/merge.js

[sasurau4]

I'd like to help with commands/tools/copyFiles.js 👍

[anikethsaha]

I can help with link command

[luizcieslak]

I'd like to work with commands/tools/copyAndReplace.js!

[pveyes]

I'd like to help with command/tools/findSymlinkedModules.js 👋

[konojunya]

I'd like to help with commands/tools/assertRequiredOptions.js💪

[moriyuu]

I'd like to help with commands/tools/packageManager.js !

[radko93]

I can do loadMetroConfig.js, isValidPackageName.js and assign.js

[thymikee]

There's only 5 files/directories left unassigned. You are amazing! 💕
EDIT: Nothing left!

[KangYoosam]

I'd like to help with commands/tools/generator/ 😁

[assuncaocharles]

Hey, I do like to start helping with
commands/tools/gracefulifyFs.js and then take something bigger. :D

Btw, it seems commands/tools/install.js is done

[Quadriphobs1]

I'd like to help with commands/bundle 😄

[troZee]

I would like to help with commands/tools/config/

WIP MR https://github.com/react-native-community/cli/pull/710

[Noeza]

I would like to help if there are any files left, not yet taken

[thymikee]

@Noeza you could take a look at __e2e__ directory and convert tests. We would also use some help with reviewing PRs :)

[nitaking]

I want to raise my hand for the next help!

[Sly777]

I can also help with code review or for converting tests.

[nickytonline]

Anything else to grab? I helped migrate the Refined GitHub extension to TS. Happy to work on any part of this.

[thymikee]

Looks like we're out of work that's not assigned to anybody. But maybe we missed something, so feel free to identify that. If not, code review is always welcome. Or PRs improving type coverage!

[troZee]

@nitaking @Sly777 @nickytonline
I am struggling with this PR https://github.com/react-native-community/cli/pull/710 . Can you help me with this ?

[nickytonline]

I'll take a peek tonight @ptrocki.

[grabbou]

We have just replaced the remaining files as a part of #783.