Cli: Heroku Toolbelt fails on updating (Windows)

[dbuendiab]

Every time I try a heroku command it seems Toolbelt tries to update itself but it fails when renaming node.exe, a file that already exists in the %HOME%/.heroku dir.

[dbuendiab]

I've tried reinstalling Heroku after installing NodeJS and now it works. Maybe this is a dependence but I haven't read about it.

[jdxcode]

can you update and try again?

[dbuendiab]

I've seen today it is failing again - but I'm sure it worked 3 days ago! :(

I've uninstalled NodeJS and Heroku and installed again, first NodeJS, then Heroku. Still getting the same screen capture.

[jdxcode]

can you show me the output of heroku version? Also, having node installed won't do anything, the toolbelt won't use any local installation of node, it needs it's own so that it won't conflict.

[dbuendiab]

That's new: after trying to install itselfs again (seems autoupdate), downloads node in tmp file, cannot overwrite node, and then the three plugin errors before the version data info. What I had not viewed before is the Heroku client internal error that follows.

C:\Users\Diego Buendia>heroku version
Installing Heroku Toolbelt v4... done.
For more information on Toolbelt v4: https://github.com/heroku/heroku-cli
Setting up node-v4.1.1... ! rename C:\Users\Diego Buendia\AppData\Local\heroku\tmp\download15
078399\file C:\Users\Diego Buendia\AppData\Local\heroku\node-v4.1.1-windows-x86\bin\node.exe: Ac
eso denegado.
error loading plugin commands
error loading plugin topics
error loading plugin commands
heroku/toolbelt/3.42.9 (i386-mingw32) ruby/1.9.3
! Heroku client internal error.
! Search for help at: https://help.heroku.com
! Or report a bug at: https://github.com/heroku/heroku/issues/new

Error:       No such file or directory - "C:\Users\Diego Buendia\AppData\Local/heroku/heroku

cli.exe" version (Errno::ENOENT)
Command: heroku version
Version: heroku/toolbelt/3.42.9 (i386-mingw32) ruby/1.9.3
Error ID: 2e63255be9664040b0f8896f0fedeb80

[jdxcode]

@dbuendiab the path looks very suspicious with the backslash and forward slashes. What shell are you using?

[dbuendiab]

In the opening post I stated it was on Windows (8.1, BTW), but in the next I took it for granted, excuse me if I fooled you. The error is the same usind CMD or Powershell.

[jdxcode]

:) sorry about that. I should've checked above. I tested myself in powershell and while it does show the odd backslashes combined with forward slashes, it still functions. I'm wondering if this might be the space in your username. Checking now.

[dbuendiab]

Probably you're right. I'm on the road now, I'll check when arriving at home.

[jdxcode]

I created an account myself in my windows vm with a space in the name in powershell, but it functioned fine. I am on win10 though, I don't have a win8.1 vm handy. I may have to get one setup for this, but I don't feel like the windows version is likely the problem.

I think it goes without saying if it IS the space in the username, it's clearly a major bug.

[jdxcode]

I wonder if this is a permissions issue. Did you happen to run the command as an administrator then as not an admin? Can you check the C:\Users\Diego Buendia\AppData\Local\heroku directory for the node folder and see what the permissions are on it?

[jdxcode]

I'm thinking this is a permissions or a partial download issue. If you could also show me a list of all the files in C:\Users\Diego Buendia\AppData\Local\heroku\node-v4.1.1-windows-x86 I think I can figure it out and repro it.

Not sure if powershell has a tree command, but that would be ideal.

[dbuendiab]

Luckily we've got tree in CMD:

C:\Users\Diego Buendia\AppData\Local\heroku>tree
Listado de rutas de carpetas para el volumen OS
El número de serie del volumen es CE29-AFDB
C:.
├───node-v4.1.1-windows-x86
│   └───bin
└───tmp
    ├───download012586627
    ├───download153078399
    ├───download282383147
    ├───download519054720
    ├───download577696091
    ├───download641124015
    ├───download929530299
    ├───download984129015
    └───download997150727

Got the permissions using Git Bash (this machine is only-one-user, never dealed with admin except when installing something). The node.exe file has `-rwxr-xr-x' permissions, but I don't know if it's right or wrong. After this, I've opened a CMD with 'run as administrator' mode, and the error raises again as before.

Diego Buendia@db MINGW64 ~/AppData/Local/heroku
$ ls -LRl
.:
total 265
-rw-r--r-- 1 Diego Buendia 197610     38 sep. 28 22:28 autoupdate
-rw-r--r-- 1 Diego Buendia 197610 258424 sep. 28 22:28 cacert.pem
-rw-r--r-- 1 Diego Buendia 197610   3139 sep. 30 08:15 error.log
drwxr-xr-x 1 Diego Buendia 197610      0 sep. 28 22:28 node-v4.1.1-windows-x86/
drwxr-xr-x 1 Diego Buendia 197610      0 sep. 30 08:15 tmp/

./node-v4.1.1-windows-x86:
total 0
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 22:28 bin/

./node-v4.1.1-windows-x86/bin:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 22:28 node.exe*

./tmp:
total 0
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 23:03 download012586627/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 29 23:33 download153078399/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 29 00:27 download282383147/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 22:28 download519054720/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 23:02 download577696091/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 30 08:15 download641124015/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 22:29 download929530299/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 23:02 download984129015/
drwxr-xr-x 1 Diego Buendia 197610 0 sep. 28 22:30 download997150727/

./tmp/download012586627:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 23:03 file*

./tmp/download153078399:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 29 23:33 file*

./tmp/download282383147:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 29 00:27 file*

./tmp/download519054720:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 22:28 file*

./tmp/download577696091:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 23:03 file*

./tmp/download641124015:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 30 08:15 file*

./tmp/download929530299:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 22:29 file*

./tmp/download984129015:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 23:02 file*

./tmp/download997150727:
total 10420
-rwxr-xr-x 1 Diego Buendia 197610 10669160 sep. 28 22:30 file*

[dbuendiab]

I see tree doesn't show files, excuse me:

C:\Users\Diego Buendia\AppData\Local\heroku>tree /F
Listado de rutas de carpetas para el volumen OS
El número de serie del volumen es CE29-AFDB
C:.
│   autoupdate
│   cacert.pem
│   error.log
│
├───node-v4.1.1-windows-x86
│   └───bin
│           node.exe
│
└───tmp
    ├───download012586627
    │       file
    │
    ├───download153078399
    │       file
    │
    ├───download282383147
    │       file
    │
    ├───download519054720
    │       file
    │
    ├───download541402143
    │       file
    │
    ├───download577696091
    │       file
    │
    ├───download641124015
    │       file
    │
    ├───download701168019
    │       file
    │
    ├───download929530299
    │       file
    │
    ├───download984129015
    │       file
    │
    └───download997150727
            file

[jdxcode]

@dbuendiab apologies but I'm going to be out the next few days on vacation. This bug has proven to be pretty tricky to solve, I hope to get it fixed soon. I believe you can fix this yourself at least in the meantime by deleting the entire %LOCALAPPDATA%\heroku directory.

[jdxcode]

I do appreciate the detailed information about the file structure. Unfortunately I'm still not sure what exactly is happening, that file should be deleted before it's moved and it also shouldn't attempt to download it if it already exists, very strange. Still looking.

[jdxcode]

Still working on this btw, haven't found the issue yet.

[jdxcode]

Alright I don't have a fix, but I added some hopefully better debugging around this. Can someone that has this issue delete %LOCALAPPDATA%\heroku and try again? There should hopefully be some more output about whatever the actual issue is.

[dbuendiab]

Well I've deleted the folder and restarted heroku:

After a while, it seems to work without updating. Good job!

[jdxcode]

seriously!? this was the change https://github.com/heroku/heroku-cli/commit/0215bc485e9e39e597e751fdade6ac16bec99d44

I did not think that would fix it, oh well though. I'm happy to finally have this fixed! Thanks for your patience.

[dbuendiab]

Well, maybe someone could try on another Windows version to added confirmation. For your information, I'm using Windows 8.1 and I've tried several commands and the old behaviour is gone.

[jdxcode]

If anyone is still getting this issue, delete %LOCALAPPDATA%\heroku and try again. It should be resolved.

[gusbicalho]

I had the bug, and now it works for me too.