Cli-microsoft365: Bug report: `spfx project upgrade` path issue

Created on 9 Oct 2020  路  6Comments  路  Source: pnp/cli-microsoft365

Description

If there is a space in the path for the project, the Execute script section of the output for spfx project upgrade may not run without error.

For example, I have a project at D:\code\Clientname Legal\Solution. The script ends up with commands like:
mkdir D:\code\Clientname Legal\Solutions\MatterExtension/teams, which fails due to the space.

It would seem the fix would be to always wrap the path in double quotes to reduce the possibility of these errors.

[Whether or not I should have a space in my paths isn't the point. :) ]

Environment

Windows 10, m365 CLI version 3.0.0

bug work in progress

Most helpful comment

Thanks, @waldekmastykarz!

All 6 comments

Thanks for reporting this @sympmarc and apologies for the trouble, we will take a look ASAP.

I worked around it easily. But it might get others stuck.

@waldekmastykarz - It's not just the mkdir command. There are others where the space causes a problem.

Gotcha. Thought it was specific to mkdir. Thank you for bringing it up 馃憤

This should be fixed in the latest preview version that we have just released. Thanks again for reporting @sympmarc 馃憦

Thanks, @waldekmastykarz!

Was this page helpful?
0 / 5 - 0 ratings