Cli-microsoft365: Enhancement: Extend command `tenant status list` with support for optional filter for workload

Created on 26 Jul 2020  路  9Comments  路  Source: pnp/cli-microsoft365

We currently have no option in command tenant status list to filter with workload, therefore we should introduce a new option called -w, --workload [workload] to allow retrieval of the current service status of only one particular service. If not provided, list the current service status of all services will be returned

enhancement work in progress

Most helpful comment

Hi @arjunumenon the default output can remain the same but if output option json is provided then everything should be printed out, like all other commands.

All 9 comments

Hey @rabwill - Do you mind If I take this up?

Absolutely do not mind at all @arjunumenon 馃槃. Thank you so much for helping out 馃帀

Hey @rabwill , when I was delving into the code base, I see that there is a similar command for getting the health status of O365 Services, which is m365 tenant status list which is created based on #1272 .

With the above command specs, are we trying to get the details with an added workload filter. Or we are trying to enhance the command m365 tenant status list with more output details. Isn't that going to be duplicate of already available command? Your thoughts please.

Nice catch @arjunumenon ! looks like it is already implemented. Like you said let's make it as an enhancement to add a workload filter.

Hey @garrytrinder @waldekmastykarz I have updated this command spec, as @arjunumenon rightly pointed out, the command is infact already existing as tenant status list. (I guess the command name implemented for issue 1272 is slightly different than the spec)
So with this enhancement, we can add the filter for workload. Does that all make sense?

Yes, good idea and very good catch @arjunumenon 馃憦

Hey @waldekmastykarz / @rabwill - Thanks for the suggestion. I will be going ahead with the enhancement by adding the filter for workload .

Another question I had on the same.
I am assuming we do not want to change the output values for the command, right? Currently it shows only Name and Status as the default output.
image

We do not want to do have additional values in the output unlike the execution of Get-PnPOffice365CurrentServiceStatus, do we?
Below is what we get for PowerShell execution.
image

Can you give your thoughts on that also please.

Hi @arjunumenon the default output can remain the same but if output option json is provided then everything should be printed out, like all other commands.

Awesome @rabwill . That clears it. Thanks for the direction.

Was this page helpful?
0 / 5 - 0 ratings