Cli-microsoft365: Bug report: pnp.github.io Sample Scripts pages need an updated URLs

[alexandair]

Description

It looks like when repo got reorganized and "sample-scripts" changed to "examples, pnp.github.io Sample Scripts URLs are not updated.

https://pnp.github.io/office365-cli/sample-scripts/graph/call-graph/ should be https://pnp.github.io/office365-cli/examples/graph/call-graph/

Right now, the Sample Scripts pages are not updated when examples are updated in the GitHub repo, and the edit button redirects to 404 page.

[waldekmastykarz]

Good catch! @garrytrinder, we need to rename the folder with script samples to match the URL we use in the docs to fix the edit functionality.

[garrytrinder]

This is an interesting one, the dev branch shows the correct folder name but master does not.

https://github.com/pnp/office365-cli/tree/master/docs/manual/docs

https://github.com/pnp/office365-cli/tree/dev/docs/manual/docs

Any ideas @waldekmastykarz ?

[waldekmastykarz]

Yes, we have merged it just this past week after we've done the release. This is why the change is in dev but not in master. Seems like the edit link goes to the master branch. It will get fixed when we do the next release at the end of May. I thought it's something that we've missed but it turns out to be just poor planning on my end. Sorry for that.

Shall we keep this issue open until the next release so that we can verify that everything works as expected?

[garrytrinder]

Happy to leave this fix till the next release.

The only impact is the GitHub link not working from what I can see, all other menu links work as expected.

Thank you for bringing this to our attention @alexandair 👍🏻

[alexandair]

Thank you.

Another impact is that content on pnp.github.io is not in sync with the GitHub repo.
For example, the call_graph example to get the access token contains 2 code blocks (for PowerShell and Bash) in the repo, and only PowerShell one on the site.

[waldekmastykarz]

The code is displayed in tabs which perhaps isn't as clear as it should've been. Do you mean this:

[alexandair]

Oh, I've missed that. Thanks.

[waldekmastykarz]

We have just released an update to the docs and this issue is now fixed. Once again, thank you for bringing it to our attention @alexandair 👏