Cli-microsoft365: Discussion: Message to display when no upgrade needed
Description
Running spfx project upgrade on a component that is at the current level results in an error:
"Error: Project doesn't need to be upgraded"
Environment
o365 cli: 2.8.0-beta.ee3c531
Discussion
Since the result of the operation (project being a current spfx version) is the same as what is expected, I don't believe the message should be displayed in red and contain the word "Error".
pschaeflein
All 5 comments
Agreed @pschaeflein. @VelinGeorgiev @garrytrinder any objections in treating this as a bug and changing to what Paul proposed?
@StfBauer would this affect the integration in @pnp/spfx?
waldekmastykarz
on 13 Mar 2020
Agreed, sounds like a bug to me, we should return a more appropriate response.
garrytrinder
on 13 Mar 2020
Agreed.
VelinGeorgiev
on 13 Mar 2020
@waldekmastykarz No effect on the integration cause I only use the message and not the error code. So it is might only an issue in the output of the CLI I guess.
StfBauer
on 17 Mar 2020
Thanks for confirming @StfBauer
waldekmastykarz
on 19 Mar 2020
Related issues
joshua-probst
路
3Comments
waldekmastykarz
路
3Comments
plamber
路
3Comments
phillipharding
路
3Comments
andrewconnell
路
3Comments
Most helpful comment
Agreed @pschaeflein. @VelinGeorgiev @garrytrinder any objections in treating this as a bug and changing to what Paul proposed?
@StfBauer would this affect the integration in @pnp/spfx?