Cli-microsoft365: New command: rename site collection

[waldekmastykarz]

Usage

spo site rename [options]

Description

Renames the specified site collection

Options

Option | Description
-- | --
-u, --siteUrl | The URL of the site to rename
--newSiteUrl [newSiteUrl] | New URL for the site
--newSiteTitle [newSiteTitle] | New title for the site
--suppressMarketplaceAppCheck | Suppress marketplace app check
--suppressWorkflow2013Check | Suppress 2013 workflow check
--wait | Wait for the job to complete
-o, --output [output] | Output type. json\|text. Default text
--verbose | Runs command with verbose logging
--debug | Runs command with debug logging

Additional Information

Equivalent of the Start-SPOSiteRename cmdlet

[DaveCalGH]

@waldekmastykarz I can take this one if it hasn't already been allocated.

[VelinGeorgiev]

@DaveCalGH, done.

[waldekmastykarz]

Awesome! Appreciate your help @DaveCalGH 👏

[DaveCalGH]

I'm a bit stuck on the test coverage with this one. I have a branch checked in with the new functionality at https://github.com/DaveCalGH/office365-cli/tree/issue-1197
I believe my test cases are complete but the coverage report keeps saying line 24 in uncovered but that line is the beginning of the class itself:
class SpoSiteRenameCommand extends SpoCommand {
I've never written test cases that involve setTimeout but I copied the same pattern implemented by site-classic-remove. I was hoping someone would be able to take a look at my branch or give me some pointers for debugging this?

[VelinGeorgiev]

Thanks, @DaveCalGH! I will try to find some time and have a look at your code this week.

[DaveCalGH]

@VelinGeorgiev I likely wasted way more time on it than necessary but I think I have it under control now. I will do some more verification before sending over a pull request.

[VelinGeorgiev]

@DaveCalGH I am sorry, I was not able to make it for the last week. I could have saved you some time.

[DaveCalGH]

@VelinGeorgiev the sentiment is appreciated. I was able to get the satisfaction of finally getting it to work 😁 Pull request #1269

[VelinGeorgiev]

Thank you very much @DaveCalGH! We'll review shortly.