Cli-microsoft365: spfx project externalize: doesn't work with @pnp/spfx-property-controls and @pnp/spfx-controls-react

[baywet]

Hi,
I'm adding an issue here to help share the information.
The main issue is how the module is defined currently for those library. (commonjs)
Added issues on the respectives repos to help solve this.
https://github.com/SharePoint/sp-dev-fx-property-controls/issues/205
https://github.com/SharePoint/sp-dev-fx-controls-react/issues/415

[waldekmastykarz]

Is this an issue on our end because we incorrectly determine the module type or is it something that needs to be addressed in the respective projects?

[baywet]

IMHO it needs to be addressed in the respective projects. I was adding the issue here to provide visibility to people using the command.

[waldekmastykarz]

Since there is no work on our end for it, shall we close it?

[baywet]

It's up to you, my opinion would be to leave it open to provide visibility to people as long as things need to be fixed. Closed issues are harder to come by, they are not indexed the same by search engines in my experience.

[waldekmastykarz]

We use issues as a backlog and if there is nothing that we can do about it, I'd prefer to close it. We have the reference, so shall anything come up, it should be possible to find it in this issue list.

[baywet]

I'll go ahead and close it then, I wouldn't want to go against this repo's etiquette and practices :)