Cli-microsoft365: Fix Nodejs 10x `Buffer()` deprication warning
When I run command using the CLI with Nodejs 10.x, I get the following message:
C:\p\office365-cli (orgassets-list -> origin) (@pnp/[email protected])
位 o365 spo orgassetslibrary list --debug
(node:7184) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Expected:
- No deprecation warnings
VelinGeorgiev
All 8 comments
@VelinGeorgiev is this coming from a feature branch? It seems that the dev branch doesn't have this command.
waldekmastykarz
on 24 Aug 2019
That alers pops on every commamd. Try o365 login and you'll get it if you use Nodejs10
VelinGeorgiev
on 25 Aug 2019
I ran o365 login on Node 10.15.3 and didn't get the warning.
waldekmastykarz
on 25 Aug 2019
Well we have to see where in the solution use Buffer() and change it to Buffer.alloc() || Buffer()
VelinGeorgiev
on 25 Aug 2019
I'm not sure if we use it in our code at all. I suspect our downstream dependencies, but let's have another look to get a solid repro case.
waldekmastykarz
on 26 Aug 2019
I can see the issue when running the CLI in Node v10.16.3 on Windows.
waldekmastykarz
on 27 Aug 2019
The reason this issue is visible only on Windows is because we're using the deprecated call in the WindowsTokenStorage, here:
and here:
I'll try to get it fixed before we ship v2.
waldekmastykarz
on 27 Aug 2019
Merged manually. Thanks!
VelinGeorgiev
on 28 Aug 2019
Related issues
waldekmastykarz
路
3Comments
VelinGeorgiev
路
3Comments
rabwill
路
3Comments
joshua-probst
路
3Comments
arjunumenon
路
3Comments
Most helpful comment
The reason this issue is visible only on Windows is because we're using the deprecated call in the WindowsTokenStorage, here:
https://github.com/pnp/office365-cli/blob/5e0d6efa37b3b0478a0de13bcf7df5319eeced8a/src/auth/WindowsTokenStorage.ts#L100
and here:
https://github.com/pnp/office365-cli/blob/5e0d6efa37b3b0478a0de13bcf7df5319eeced8a/src/auth/WindowsTokenStorage.ts#L134
I'll try to get it fixed before we ship v2.