Cli-microsoft365: Upgrade our Microsoft Teams commands from beta to GA endpoints

Created on 11 Mar 2019  路  9Comments  路  Source: pnp/cli-microsoft365

Many of our rest endpoints are still using graph beta endpoints, should we change them to v1.0 instead so we are updated as well?
Below are the commands which can be upgraded to API v1.0

  • [ ] o365group list
  • [ ] o365group restore
  • [ ] graph teams channel add
  • [ ] ~graph teams list~
  • [ ] graph teams channel list
enhancement work in progress

Most helpful comment

There are indeed differences in how the v1.0 and beta endpoints in MS Graph behave. @rabwill is working on updating the beta commands to v1.0. Ideally, we should try to build commands on v1.0. If not possible, only then we should defer to using beta endpoints. Hope this helps @thomyg.

All 9 comments

Sounds like a good idea! Could you please add here a list of all commands that we should update so that we can track the progress and verify that we haven't missed anything? We could then include all of them in a single PR including removing the beta remark from the docs.

Sounds like a good idea! Could you please add here a list of all commands that we should update so that we can track the progress and verify that we haven't missed anything? We could then include all of them in a single PR including removing the beta remark from the docs.

Hey @waldekmastykarz I have updated the issue with the list of commands.

Perfect! I've just turned them into a checklist so that we can track the progress. Would you like to pick it up yourself @rabwill?

Yeah sure why not :)

Awesome!

@waldekmastykarz I started playing with the CLI with creating the graph teams tab list command. To get started I copied the code of graph teams list in my new command and started playing. First thing I changed was the beta endpoint to V1. I got it working but I get back a totally different result set than by using the beta endpoint. I'm assuming /beta/groups?$filter=resourceProvisioningOptions/Any(x:x eq 'Team')&$select=id,displayName,description` includes already archived teams also. That's the main difference I see in my tenant between the two result sets. How should I proceed? Should I create a PR for an update to graph teams list or can you confirm my assumption already with this post?

There are indeed differences in how the v1.0 and beta endpoints in MS Graph behave. @rabwill is working on updating the beta commands to v1.0. Ideally, we should try to build commands on v1.0. If not possible, only then we should defer to using beta endpoints. Hope this helps @thomyg.

Hey @waldekmastykarz seems like the graph v1.0 command to filter groups do not support filter yet see ms doc here so from the list I am excluding graph teams list rest are fine to go ahead with v1.0. Does that sound good?

Absolutely @rabwill 馃憦

Was this page helpful?
0 / 5 - 0 ratings