Cli-microsoft365: New command: Update fun settings of a Microsoft Teams team

[waldekmastykarz]

Updates fun settings of a Microsoft Teams team

• command: teams funsettings set -i|--teamId <teamId> --allowGiphy [allowGiphy] --giphyContentRating [giphyContentRating] --allowStickersAndMemes [allowStickersAndMemes] --allowCustomMemes [allowCustomMemes]
• teamId - The ID of team for which to update fun settings
• allowGiphy - Set to true to allow giphy and to false to disable it
• giphyContentRating - Settings to set content rating for giphy. Allowed values Strict|Moderate
• allowStickersAndMemes - Set to true to allow stickers and memes and to false to disable them
• allowCustomMemes - Set to true to allow custom memes and to false to disable them

[arnieraju]

@waldekmastykarz I would love to give this one a crack. Can you assign me to this also?

[waldekmastykarz]

All yours! 💪

[arnieraju]

Just a quick update. I've started getting into this one now.

[waldekmastykarz]

Thanks for the update @arnieraju 👏

[waldekmastykarz]

Are you still working on it @arnieraju?

[arnieraju]

@waldekmastykarz thanks for the message! I've been waylaid with work, but this is still on my radar! Hoping to be back onto this by the end of next week if that works for you and the team. If not I am happy if someone else has got their eye on this before then.

[waldekmastykarz]

Thanks for the reply, @arnieraju. By the end of next week is good! Looking forward to your PR!

[arnieraju]

@waldekmastykarz and team, PR #997 submitted ready for your review.

There was one conflict with the npm-shrinkwrap.json. In future would you like me to just pull through the latest from dev before submitting?

[waldekmastykarz]

@arnieraju rebasing your fork to upstream before submitting a PR is always a good idea. It decreases the chances of merge conflicts and makes it easier for us to review and merge your PR. 👍

[VelinGeorgiev]

@arnieraju, I never commit npm-shrinkwrap.json file. You can just discard it and let Waldek update it when needed.

[arnieraju]

@VelinGeorgiev Good to know! After I saw the conflict I did have my suspicions! Thanks for the tip! :)

[arnieraju]

Okay Take 2 with PR #999! :) Cleaned up and ready for review