Cli-microsoft365: New command: enable site classification

[waldekmastykarz]

Enable site classification

• command: graph siteclassification enable -c|--classifications <classifications> -d|--defaultClassification <defaultClassification> --usageGuidelinesUrl [usageGuidelinesUrl]
• classifications: comma-separated list of classifications to enable in the tenant
• defaultClassifications: classification to use by default
• usageGuidelinesUrl: URL with additional information that should be displayed when choosing the classification for the given site
• requires connection to the Microsoft Graph (#10)

For more information see the Enable-PnPSiteClassification cmdlet

[appieschot]

More than happy to pick this one up.

[waldekmastykarz]

W00t! All yours! 🚀

[waldekmastykarz]

Hey @appieschot, are you still working on this command?

[appieschot]

And we'll do a retry; happy to pick this one up :)

[waldekmastykarz]

All yours!

[appieschot]

Do you want to implement a -disable: flag on this method to disable site classifications, or do you want to have an additional command called disable site classification (as testing the creation without the option to delete is a bit weird)? If it is an additional command I would love to pick it up in the same PR.

Additionally we do have a property called GuestUsageGuidelinesUrl in the directorysettings. We could leverage that as in this same method as well.

[waldekmastykarz]

Let's use a separate command for disable. If we don't have an issue for it, let's create one.

Good idea to include GuestUsageGuidelinesUrl 👍

[ypcode]

If i may, i started but not finished up the site classification set command... it is already working, just need to ensure the code coverage and .md page, wouldn’t it be more productive to sync on such related commands?

[appieschot]

@ypcode that would definitely make sense, do you have the command synced to your repo? I have the command implemented as well but do also need the tests and documentation :). You can find my implementation on: https://github.com/appieschot/office365-cli/tree/feature/enable-site-classification

[ypcode]

Let me make sure it is, I will do it tonight

[ypcode]

Here is the current state of this future PR : https://github.com/ypcode/office365-cli/tree/dev-graph-site-classification-set. As I said, the docs and testing are not done, will do it after being back from vacation after September, 10th.

I didn't check yours @appieschot , but maybe we can have some sort of sync in each other PRs.

Will be more active soon :)
Cheers,
Yannick

[appieschot]

@ypcode i just wrote my tests, but have a slightly different implementation than yours. I did use the PowerShell code sample, but will consolidate with your implementation to ease integration in the next release. The set requires one additional property (DefaultValue) as when enabling it, it requires the default value for usageGuidelinesUrl when it is not specified