Clay: Wondering if we need/use some RTL icons

Created on 18 May 2021  路  8Comments  路  Source: liferay/clay

Just wondering if we are currently using RTL icons and why we created some of them

I think we could remove some of them since their meaning is not changing or providing new or better information in RTL version. They are:

  • copy-rtl (it is a standard icon, just a quick review in other tools to see they don't usually change it in RTL)
  • flag-empty-rtl (the wind changed? haha)
  • flag-full-rtl
  • paste-plaintext-rtl (no meaning changes)
  • paste-word-rtl (no meaning changes)

image

icons question

Most helpful comment

Can we just use this issue?

All 8 comments

Yeah you are right @marcoscv-work, I agree.

As I said in #175 I made some icons that don't make sense to keep it, most of them caused by the rush to complete the icon set.

But the rules are clear, if the direction of the icons doesn't give additional context it's because RTL is not needed. For example, bullet-list and numbered-list should have an RTL version.

The direction of the wind is important 馃槄

Then can we create an issue to review and resolve this?
Probably those icons are not in use but we need to confirm it

Let's do it!

Can we just use this issue?

It makes sense to me, I think we need to create a new ticket to analyze the use of icons in DXP, and when we finish analyzing we will remove the icons from Clay

Checked, no uses of those icons in DXP:
https://issues.liferay.com/browse/LPS-132516

Thanks @marcoscv-work, so I think it's safe to remove it from Clay

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130565

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bryceosterhaus picture bryceosterhaus  路  5Comments

brunofarache picture brunofarache  路  5Comments

ethib137 picture ethib137  路  4Comments

bryceosterhaus picture bryceosterhaus  路  4Comments

julien picture julien  路  3Comments