Clay: Reorganize clay-css and clay npm packages

Created on 24 Apr 2018  路  6Comments  路  Source: liferay/clay

In order to fully leverage cdns like https://unpkg.com/ or https://www.jsdelivr.com/, we need to have a nice npm package published.

There's still some confusion with the current clay package, as it pretty much brings only css.

For these reasons, I'm proposing:

  • Rename clay to clay-css
  • Create a clay package that exposes the compiled css and js bundling all components and resources

Unless someone heavily disagrees, I'll send a PR with these changes later ;)

/cc @matuzalemsteles, @julien, @carloslancha, @pat270

Fair warning, @bryceosterhaus, @mthadley, as this might affect you... what are you currently using and how?

enhancement

Most helpful comment

That's what I think, yeah... we would have:

  • clay -> For distribution purposes only and usage through cdn
  • clay-css -> CSS framework and implementation
  • clay-* -> UI components (js + soy + webcomponents)

Does that make sense? Is there any other way this would be more easily understandable?

All 6 comments

@jbalsas I'm totally OK with that proposition.

We are bundling the CSS from the current clay package. More specifically, we are depending on the includePaths export from the package, and passing that to sass-loader.

So for us, this would be a breaking change, and we would need to instead depend on this new clay-css package. Thankfully, this seems like it wouldn't be much trouble for us to fix.

Would it might make sense for this clay distributable package to include sources... specially scss and ES+ which could be rebundled from the different individual packages, or is it better to assume the breaking change?

After all, you won't be needing the rest of things in there...

I don't think the breaking change is a big deal for us. Also, it should lead to a more cleanly organized set of packages, right?

That's what I think, yeah... we would have:

  • clay -> For distribution purposes only and usage through cdn
  • clay-css -> CSS framework and implementation
  • clay-* -> UI components (js + soy + webcomponents)

Does that make sense? Is there any other way this would be more easily understandable?

This has been done and published as rc.12 to verify. @mthadley, can you guys check if switching to clay-css keeps working the same way for you?

Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

drakonux picture drakonux  路  3Comments

drakonux picture drakonux  路  4Comments

drakonux picture drakonux  路  4Comments

julien picture julien  路  3Comments

bryceosterhaus picture bryceosterhaus  路  5Comments