Clarity: Modal produces an error when pressing ESC key

[whizkidwwe1217]

Select one ... (check one with "x")

[x] bug
[ ] feature request
[ ] enhancement

Expected behavior

An html with a modal component should not produce errors when pressing the ESC key.

Actual behavior

When the modal is hidden, when pressing the ESC key, it's generating an error:

Reproduction of behavior

• Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:
  
  

Environment details

• Angular version: 4.3.6

• Clarity version: 0.10.6

• OS and version:

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

[mathisscott]

Hi @whizkidwwe1217
I know how much you ❤️ plunkr. But could you replicate your issue in one this time?

I've tried reproducing this on both the website and plunkr and cannot.

[whizkidwwe1217]

Hi @mathisscott
You can definitely replicate it with the default plunkr. To replicate it, don't open up or show the modal. Just run the plunkr and hit the ESC key. :-)

[mathisscott]

Ah. Got it. I was opening the modal first.

I'll try replicating it again on Monday. Thanks!

[whizkidwwe1217]

@mathisscott Thanks!

[hippee-lee]

@mathisscott this issue is related to https://github.com/vmware/clarity/pull/1472
In this case, it should be putting focus onto the body.

I'll look into it.

[github-actions[bot]]

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.